From: Mark Levedahl <mlevedahl@gmail.com>
To: git@vger.kernel.org
Cc: Mark Levedahl <mlevedahl@gmail.com>
Subject: [PATCH] Cygwin has trustable filemode
Date: Sun, 14 Jul 2013 12:13:10 -0400 [thread overview]
Message-ID: <1373818390-14451-1-git-send-email-mlevedahl@gmail.com> (raw)
The supported Cygwin distribution on supported Windows versions provides
complete support for POSIX filemodes, so enable this by default. git as
distributed by the Cygwin project is configured this way.
This fixes one testsuite failure:
t3300 test 17 (diff-index -M -p with mode change quotes funny filename)
Historical notes: Earlier versions of Cygwin (version 1.5 and prior) had
various methods for supporting posix file modes on different file systems,
often using extended attributes, and this support was optional. Such
versions of Cygwin are not available on any public mirror and are not
supported by the Cygwin project. The currently available Cygwin supports
POSIX file modes without exception - this is not an optional
configuration. The support does depend upon the underlying file system
(neither Linux nor Cygwin can set an execute bit on a FAT file system as
FAT has no such support), but as this is no different than Linux, the
default should not treat Cygwin differently than Linux.
Users who desire the non-POSIX mode of operation must explicitly set
core.filemode=False, accepting non-interoperability with Linux.
Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
config.mak.uname | 1 -
1 file changed, 1 deletion(-)
diff --git a/config.mak.uname b/config.mak.uname
index 7ac541e..779d06a 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -163,7 +163,6 @@ ifeq ($(uname_O),Cygwin)
NO_THREAD_SAFE_PREAD = YesPlease
NEEDS_LIBICONV = YesPlease
NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
- NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease
# There are conflicting reports about this.
# On some boxes NO_MMAP is needed, and not so elsewhere.
--
1.8.3.2.0.13
next reply other threads:[~2013-07-14 16:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 16:13 Mark Levedahl [this message]
2013-07-16 21:20 ` [PATCH] Cygwin has trustable filemode Ramsay Jones
2013-07-16 23:22 ` Mark Levedahl
2013-07-19 14:53 ` Mark Levedahl
2013-07-19 16:40 ` Junio C Hamano
2013-07-19 18:17 ` Mark Levedahl
2013-07-19 19:16 ` Junio C Hamano
2013-07-19 23:07 ` Mark Levedahl
2013-07-19 23:08 ` [PATCH 1/4] Cygwin 1.7 " Mark Levedahl
2013-07-19 23:08 ` [PATCH 2/4] Cygwin 1.7 needs compat/regex Mark Levedahl
2013-07-19 23:08 ` [PATCH 3/4] Cygwin 1.7 has thread-safe pread Mark Levedahl
2013-07-19 23:08 ` [PATCH 4/4] Cygwin 1.7 supports mmap Mark Levedahl
2013-07-19 23:09 ` [PATCH] Cygwin has trustable filemode Jonathan Nieder
2013-07-20 20:12 ` Ramsay Jones
2013-07-20 19:52 ` Ramsay Jones
2013-07-21 21:56 ` Junio C Hamano
2013-07-22 3:30 ` Mark Levedahl
2013-07-22 5:02 ` Junio C Hamano
2013-07-22 22:22 ` Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373818390-14451-1-git-send-email-mlevedahl@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).