From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 0/2] Finishing touches to "name-rev" fix
Date: Thu, 18 Jul 2013 15:16:06 -0700 [thread overview]
Message-ID: <1374185768-7537-1-git-send-email-gitster@pobox.com> (raw)
This is an update to finish the jc/name-rev-exact-ref topic, which
fixed the command to convert an object name that points at a tag to
a refname of the tag (earlier, it did not show anything). The
codepath to handle its command line arguments, however, fed the
commit that the tag points at to the underlying naming machinery.
The first patch in this follow-up series corrects it for the command
line codepath.
The second patch is a related fix for "git describe". The command
is about naming the given commit in relation to a tag in its
neighbourhood, and while it does allow the input to be a commit-ish
(e.g. a tag that points at a commit), it did not unwrap it down to
commit, which is a bug (it is like "git commit-tree -p $tag" that
would mistakenly record a tag object as one of the parents of the
resulting commit).
Junio C Hamano (2):
name-rev: differentiate between tags and commits they point at
describe: fix --contains when a tag is given as input
builtin/describe.c | 3 ++-
builtin/name-rev.c | 41 ++++++++++++++++++++++++++++++++---------
t/t6120-describe.sh | 24 ++++++++++++++++++++++++
3 files changed, 58 insertions(+), 10 deletions(-)
--
1.8.3.3-992-gf0e5e44
next reply other threads:[~2013-07-18 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 22:16 Junio C Hamano [this message]
2013-07-18 22:16 ` [PATCH 1/2] name-rev: differentiate between tags and commits they point at Junio C Hamano
2013-07-18 22:16 ` [PATCH 2/2] describe: fix --contains when a tag is given as input Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374185768-7537-1-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).