git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Levedahl <mlevedahl@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Mark Levedahl <mlevedahl@gmail.com>
Subject: [PATCH] Cygwin has trustable filemode
Date: Fri, 19 Jul 2013 10:53:51 -0400	[thread overview]
Message-ID: <1374245631-15955-1-git-send-email-mlevedahl@gmail.com> (raw)
In-Reply-To: <1373818390-14451-1-git-send-email-mlevedahl@gmail.com>

The supported Cygwin distribution on supported Windows versions provides
complete support for POSIX filemodes, so enable this by default. git as
distributed by the Cygwin project is configured this way.

This fixes one testsuite failure:
t3300 test 17 (diff-index -M -p with mode change quotes funny filename)

Historical notes: Cygwin version 1.7 supports Windows-XP and newer, thus 
dropped support for all OS variants that lack NTFS and/or the full win32 
api, and since late 1.5 development, Cygwin maps POSIX modes to NTFS ACLs 
by default.  Cygwin 1.5 supported OS variants that used FAT as the native 
file system, and had optional methods for providing POSIX file modes on 
top of FAT12/16 and NTFS, though not FAT32.  Also, support for POSIX modes 
on top of FAT were dropped later in 1.5.  Thus, POSIX filemode support 
could not be expected by default on a Cygwin 1.5 installation, but is 
expected by default on a 1.7 installation.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
Junio - The above notes are more accurate than in my previous commit message,
so if this commit survives into next/master, I would prefer this version as
opposed to the one now on pu (da875762)

Mark

 config.mak.uname | 1 -
 1 file changed, 1 deletion(-)

diff --git a/config.mak.uname b/config.mak.uname
index 174703b..bf5db47 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -164,7 +164,6 @@ ifeq ($(uname_O),Cygwin)
 	NO_THREAD_SAFE_PREAD = YesPlease
 	NEEDS_LIBICONV = YesPlease
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
-	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
 	NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
-- 
1.8.3.2.0.13

  parent reply	other threads:[~2013-07-19 14:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14 16:13 [PATCH] Cygwin has trustable filemode Mark Levedahl
2013-07-16 21:20 ` Ramsay Jones
2013-07-16 23:22   ` Mark Levedahl
2013-07-19 14:53 ` Mark Levedahl [this message]
2013-07-19 16:40   ` Junio C Hamano
2013-07-19 18:17     ` Mark Levedahl
2013-07-19 19:16       ` Junio C Hamano
2013-07-19 23:07         ` Mark Levedahl
2013-07-19 23:08           ` [PATCH 1/4] Cygwin 1.7 " Mark Levedahl
2013-07-19 23:08           ` [PATCH 2/4] Cygwin 1.7 needs compat/regex Mark Levedahl
2013-07-19 23:08           ` [PATCH 3/4] Cygwin 1.7 has thread-safe pread Mark Levedahl
2013-07-19 23:08           ` [PATCH 4/4] Cygwin 1.7 supports mmap Mark Levedahl
2013-07-19 23:09           ` [PATCH] Cygwin has trustable filemode Jonathan Nieder
2013-07-20 20:12       ` Ramsay Jones
2013-07-20 19:52   ` Ramsay Jones
2013-07-21 21:56     ` Junio C Hamano
2013-07-22  3:30       ` Mark Levedahl
2013-07-22  5:02         ` Junio C Hamano
2013-07-22 22:22           ` Mark Levedahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374245631-15955-1-git-send-email-mlevedahl@gmail.com \
    --to=mlevedahl@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).