git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Levedahl <mlevedahl@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Mark Levedahl <mlevedahl@gmail.com>
Subject: [PATCH 1/4] Cygwin 1.7 has trustable filemode
Date: Fri, 19 Jul 2013 19:08:27 -0400	[thread overview]
Message-ID: <1374275310-22388-1-git-send-email-mlevedahl@gmail.com> (raw)
In-Reply-To: <51E9C69F.7080309@gmail.com>

The current Cygwin 1.7 distribution on supported Windows versions provides
complete support for POSIX filemodes, so enable this by default. git as
distributed by the Cygwin project is configured this way. Cygwin 1.5
installations are less likely to have this support, so leave the old
default in place for those.

This fixes one testsuite failure:
t3300 test 17 (diff-index -M -p with mode change quotes funny filename)

Historical notes: Cygwin version 1.7 supports Windows-XP and newer, thus
dropped support for all OS variants that lack NTFS and/or the full win32
api, and since late 1.5 development, Cygwin maps POSIX modes to NTFS ACLs
by default.  Cygwin 1.5 supports OS variants that use FAT as the native
file system, and had optional methods for providing POSIX file modes on
top of FAT12/16 and NTFS, though not FAT32.  Also, support for POSIX modes
on top of FAT were dropped later in 1.5.  Thus, POSIX filemode support
is not expected by default on a Cygwin 1.5 installation, but is expected
by default on a 1.7 installation.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
 config.mak.uname | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config.mak.uname b/config.mak.uname
index 7ac541e..104dc44 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -158,12 +158,12 @@ ifeq ($(uname_O),Cygwin)
 		NO_MKSTEMPS = YesPlease
 		NO_SYMLINK_HEAD = YesPlease
 		NO_IPV6 = YesPlease
+		NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
 		OLD_ICONV = UnfortunatelyYes
 	endif
 	NO_THREAD_SAFE_PREAD = YesPlease
 	NEEDS_LIBICONV = YesPlease
 	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
-	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
 	NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease
 	# There are conflicting reports about this.
 	# On some boxes NO_MMAP is needed, and not so elsewhere.
-- 
1.8.3.2.0.13

  reply	other threads:[~2013-07-19 23:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14 16:13 [PATCH] Cygwin has trustable filemode Mark Levedahl
2013-07-16 21:20 ` Ramsay Jones
2013-07-16 23:22   ` Mark Levedahl
2013-07-19 14:53 ` Mark Levedahl
2013-07-19 16:40   ` Junio C Hamano
2013-07-19 18:17     ` Mark Levedahl
2013-07-19 19:16       ` Junio C Hamano
2013-07-19 23:07         ` Mark Levedahl
2013-07-19 23:08           ` Mark Levedahl [this message]
2013-07-19 23:08           ` [PATCH 2/4] Cygwin 1.7 needs compat/regex Mark Levedahl
2013-07-19 23:08           ` [PATCH 3/4] Cygwin 1.7 has thread-safe pread Mark Levedahl
2013-07-19 23:08           ` [PATCH 4/4] Cygwin 1.7 supports mmap Mark Levedahl
2013-07-19 23:09           ` [PATCH] Cygwin has trustable filemode Jonathan Nieder
2013-07-20 20:12       ` Ramsay Jones
2013-07-20 19:52   ` Ramsay Jones
2013-07-21 21:56     ` Junio C Hamano
2013-07-22  3:30       ` Mark Levedahl
2013-07-22  5:02         ` Junio C Hamano
2013-07-22 22:22           ` Mark Levedahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374275310-22388-1-git-send-email-mlevedahl@gmail.com \
    --to=mlevedahl@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).