git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Levedahl <mlevedahl@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Mark Levedahl <mlevedahl@gmail.com>
Subject: [PATCH 2/4] Cygwin 1.7 needs compat/regex
Date: Fri, 19 Jul 2013 19:08:28 -0400	[thread overview]
Message-ID: <1374275310-22388-2-git-send-email-mlevedahl@gmail.com> (raw)
In-Reply-To: <51E9C69F.7080309@gmail.com>

Cygwin v1.7 uses the regex library from newlib which does not pass git's
tests, so don't use it. This fixes failures in t4018 and t4034.

Continue to use the platform supplied regex library for earlier versions.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
 config.mak.uname | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/config.mak.uname b/config.mak.uname
index 104dc44..8652da9 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -160,6 +160,8 @@ ifeq ($(uname_O),Cygwin)
 		NO_IPV6 = YesPlease
 		NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
 		OLD_ICONV = UnfortunatelyYes
+	else
+		NO_REGEX = UnfortunatelyYes
 	endif
 	NO_THREAD_SAFE_PREAD = YesPlease
 	NEEDS_LIBICONV = YesPlease
-- 
1.8.3.2.0.13

  parent reply	other threads:[~2013-07-19 23:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14 16:13 [PATCH] Cygwin has trustable filemode Mark Levedahl
2013-07-16 21:20 ` Ramsay Jones
2013-07-16 23:22   ` Mark Levedahl
2013-07-19 14:53 ` Mark Levedahl
2013-07-19 16:40   ` Junio C Hamano
2013-07-19 18:17     ` Mark Levedahl
2013-07-19 19:16       ` Junio C Hamano
2013-07-19 23:07         ` Mark Levedahl
2013-07-19 23:08           ` [PATCH 1/4] Cygwin 1.7 " Mark Levedahl
2013-07-19 23:08           ` Mark Levedahl [this message]
2013-07-19 23:08           ` [PATCH 3/4] Cygwin 1.7 has thread-safe pread Mark Levedahl
2013-07-19 23:08           ` [PATCH 4/4] Cygwin 1.7 supports mmap Mark Levedahl
2013-07-19 23:09           ` [PATCH] Cygwin has trustable filemode Jonathan Nieder
2013-07-20 20:12       ` Ramsay Jones
2013-07-20 19:52   ` Ramsay Jones
2013-07-21 21:56     ` Junio C Hamano
2013-07-22  3:30       ` Mark Levedahl
2013-07-22  5:02         ` Junio C Hamano
2013-07-22 22:22           ` Mark Levedahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374275310-22388-2-git-send-email-mlevedahl@gmail.com \
    --to=mlevedahl@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).