From: Joern Hees <dev@joernhees.de>
To: gitster@pobox.com
Cc: git@vger.kernel.org, apelisse@gmail.com,
felipe.contreras@gmail.com, Joern Hees <dev@joernhees.de>
Subject: [PATCH v3] remotes-hg: bugfix for fetching non local remotes
Date: Thu, 25 Jul 2013 02:42:57 +0200 [thread overview]
Message-ID: <1374712977-3215-1-git-send-email-dev@joernhees.de> (raw)
6796d49 introduced a bug by making shared_path == ".git/hg' which
will most likely exist already, causing a new remote never to be
cloned and subsequently causing hg.share to fail with error msg:
"mercurial.error.RepoError: repository .git/hg not found"
Changing shared_path to ".git/hg/.shared" will solve this problem
and create a shared local mercurial repository for non local remotes.
The initial dot circumvents a name clash problem should a remote be
called "shared".
Signed-off-by: Joern Hees <dev@joernhees.de>
Mentored-by: Antoine Pelisse <apelisse@gmail.com>
Thanks-to: Junio C Hamano <gitster@pobox.com>
---
contrib/remote-helpers/git-remote-hg | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 0194c67..f4e9d1c 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -390,7 +390,7 @@ def get_repo(url, alias):
if not os.path.exists(dirname):
os.makedirs(dirname)
else:
- shared_path = os.path.join(gitdir, 'hg')
+ shared_path = os.path.join(gitdir, 'hg', '.shared')
if not os.path.exists(shared_path):
try:
hg.clone(myui, {}, url, shared_path, update=False, pull=True)
--
1.8.3.4
next reply other threads:[~2013-07-25 0:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 0:42 Joern Hees [this message]
2013-07-25 19:12 ` [PATCH v3] remotes-hg: bugfix for fetching non local remotes Felipe Contreras
2013-07-25 19:53 ` Antoine Pelisse
2013-07-25 20:40 ` Felipe Contreras
2013-07-25 21:10 ` Antoine Pelisse
2013-07-26 1:30 ` Junio C Hamano
2013-07-26 12:17 ` Jörn Hees
2013-08-04 10:38 ` [PATCH] remote-hg: Fix cloning and sharing bug Antoine Pelisse
2013-08-04 12:17 ` Jörn Hees
2013-08-04 13:31 ` Felipe Contreras
2013-08-04 13:51 ` Jörn Hees
2013-08-04 14:00 ` Felipe Contreras
2013-08-04 13:59 ` Antoine Pelisse
2013-08-04 14:24 ` Felipe Contreras
2013-08-04 13:22 ` Felipe Contreras
2013-07-26 12:16 ` [PATCH v3] remotes-hg: bugfix for fetching non local remotes Jörn Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374712977-3215-1-git-send-email-dev@joernhees.de \
--to=dev@joernhees.de \
--cc=apelisse@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).