From: Antoine Pelisse <apelisse@gmail.com>
To: git@vger.kernel.org
Cc: Antoine Pelisse <apelisse@gmail.com>
Subject: [PATCH] remote-hg: fix path when cloning with tilde expansion
Date: Mon, 5 Aug 2013 22:12:21 +0200 [thread overview]
Message-ID: <1375733541-9099-1-git-send-email-apelisse@gmail.com> (raw)
The current code fixes the path to make it absolute when cloning, but
doesn't consider tilde expansion, so that scenario fails throwing an
exception because /home/myuser/~/my/repository doesn't exists:
$ git clone hg::~/my/repository && cd repository && git fetch
Fix that by using python os.path.expanduser method.
Signed-off-by: Antoine Pelisse <apelisse@gmail.com>
---
contrib/remote-helpers/git-remote-hg | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 02404dc..4bbd296 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -1137,7 +1137,7 @@ def fix_path(alias, repo, orig_url):
url = urlparse.urlparse(orig_url, 'file')
if url.scheme != 'file' or os.path.isabs(url.path):
return
- abs_url = urlparse.urljoin("%s/" % os.getcwd(), orig_url)
+ abs_url = os.path.abspath(os.path.expanduser(orig_url))
cmd = ['git', 'config', 'remote.%s.url' % alias, "hg::%s" % abs_url]
subprocess.call(cmd)
--
1.7.9.5
next reply other threads:[~2013-08-05 20:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 20:12 Antoine Pelisse [this message]
2013-08-05 20:30 ` [PATCH] remote-hg: fix path when cloning with tilde expansion Felipe Contreras
2013-08-05 20:32 ` Antoine Pelisse
2013-08-09 17:13 ` Antoine Pelisse
2013-08-09 18:49 ` Junio C Hamano
2013-08-09 20:09 ` Antoine Pelisse
2013-08-09 20:53 ` Junio C Hamano
2013-08-09 21:19 ` Antoine Pelisse
2013-08-09 21:45 ` Junio C Hamano
2013-08-09 21:55 ` Antoine Pelisse
2013-08-09 21:55 ` Felipe Contreras
2013-08-09 22:15 ` Junio C Hamano
2013-08-09 22:28 ` Felipe Contreras
2013-08-09 23:39 ` Junio C Hamano
2013-08-09 23:43 ` Felipe Contreras
2013-08-10 5:18 ` Junio C Hamano
2013-08-10 6:39 ` Felipe Contreras
2013-08-10 6:50 ` Junio C Hamano
2013-08-10 7:07 ` Felipe Contreras
2013-08-10 15:15 ` Antoine Pelisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375733541-9099-1-git-send-email-apelisse@gmail.com \
--to=apelisse@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).