From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: [PATCH 2/2] git-remote-mediawiki: add test and check Makefile targets Date: Wed, 21 Aug 2013 10:10:17 +0200 Message-ID: <1377072617-25086-2-git-send-email-Matthieu.Moy@imag.fr> References: <1377072617-25086-1-git-send-email-Matthieu.Moy@imag.fr> Cc: Matthieu Moy To: git@vger.kernel.org, gitster@pobox.com X-From: git-owner@vger.kernel.org Wed Aug 21 10:10:45 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VC3V4-00047h-0I for gcvg-git-2@plane.gmane.org; Wed, 21 Aug 2013 10:10:42 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751606Ab3HUIKg (ORCPT ); Wed, 21 Aug 2013 04:10:36 -0400 Received: from mx1.imag.fr ([129.88.30.5]:33147 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529Ab3HUIKe (ORCPT ); Wed, 21 Aug 2013 04:10:34 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id r7L8ANGd031134 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 21 Aug 2013 10:10:23 +0200 Received: from anie.imag.fr ([129.88.7.32]) by mail-veri.imag.fr with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VC3Um-0005GU-7V; Wed, 21 Aug 2013 10:10:24 +0200 Received: from moy by anie.imag.fr with local (Exim 4.80) (envelope-from ) id 1VC3Ul-0006Xk-U7; Wed, 21 Aug 2013 10:10:23 +0200 X-Mailer: git-send-email 1.8.4.rc2.18.g030d947 In-Reply-To: <1377072617-25086-1-git-send-email-Matthieu.Moy@imag.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Wed, 21 Aug 2013 10:10:23 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: r7L8ANGd031134 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: moy@imag.fr MailScanner-NULL-Check: 1377677424.79796@cDpNxRjwfcrtyXplDKENlg Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: There are a few level 4 and 2 perlcritic issues in the current code. We make level 5 fatal, and keep level 2 as warnings so that "make check" pass. Signed-off-by: Matthieu Moy --- contrib/mw-to-git/Makefile | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/contrib/mw-to-git/Makefile b/contrib/mw-to-git/Makefile index 76fcd4d..f206f96 100644 --- a/contrib/mw-to-git/Makefile +++ b/contrib/mw-to-git/Makefile @@ -24,6 +24,11 @@ INSTLIBDIR=$(shell $(MAKE) -C $(GIT_ROOT_DIR)/perl \ all: build +test: all + $(MAKE) -C t + +check: perlcritic test + install_pm: install $(GIT_MEDIAWIKI_PM) $(INSTLIBDIR)/$(GIT_MEDIAWIKI_PM) @@ -41,4 +46,7 @@ clean: rm $(INSTLIBDIR)/$(GIT_MEDIAWIKI_PM) perlcritic: - perlcritic -2 *.perl + perlcritic -5 $(SCRIPT_PERL) + -perlcritic -2 $(SCRIPT_PERL) + +.PHONY: all test check install_pm install clean perlcritic -- 1.8.4.rc2.18.g030d947