From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Contreras Subject: [PATCH 1/3] reset: add --stage and --work options Date: Thu, 29 Aug 2013 13:19:55 -0500 Message-ID: <1377800397-5434-2-git-send-email-felipe.contreras@gmail.com> References: <20130829180129.GA4880@nysa> <1377800397-5434-1-git-send-email-felipe.contreras@gmail.com> Cc: Jonathan Nieder , Jeff King , Ramkumar Ramachandra , Felipe Contreras To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu Aug 29 20:25:04 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VF6ty-0007sf-QR for gcvg-git-2@plane.gmane.org; Thu, 29 Aug 2013 20:25:03 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754129Ab3H2SY6 (ORCPT ); Thu, 29 Aug 2013 14:24:58 -0400 Received: from mail-ob0-f176.google.com ([209.85.214.176]:38779 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754580Ab3H2SY6 (ORCPT ); Thu, 29 Aug 2013 14:24:58 -0400 Received: by mail-ob0-f176.google.com with SMTP id uz19so871285obc.21 for ; Thu, 29 Aug 2013 11:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+lXiVyITv1Ykepo/V5q2/3y8i11cDJR6ngZpzw3jsD4=; b=j90512dYc8JlUzKBpekJLmC/xB+k5NE772vpHuzQc4PisNHQfGrxKO99jVf0iS6sZD llQV32WQ3/eiowpnmRKozKKzrHxT9+ZXZN2U5Fd0MjvqgNGkmbdXv4gSVGmBHMKY/Vzf LzQuJW/U2gFVCSbWWhNsz/ybd1YUPZUa7filuhYpzUxfAEB0nsox8l18lz7J7gSSk29w d+glfNJcjjGpx+/lClR0nvkIscahYFP6w6KpApfcqdd9/poHz4TiM1mh9FhBX46uLQw4 p7Lflfjq2bWAnve3uZhom6Zivf5cKCDIPQ06fNlyFh2XSTItKg722H5PGXnnYwKfo1By B+uQ== X-Received: by 10.60.79.101 with SMTP id i5mr61951oex.100.1377800697560; Thu, 29 Aug 2013 11:24:57 -0700 (PDT) Received: from localhost (187-162-140-241.static.axtel.net. [187.162.140.241]) by mx.google.com with ESMTPSA id it7sm32727544obb.11.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 29 Aug 2013 11:24:56 -0700 (PDT) X-Mailer: git-send-email 1.8.4-fc In-Reply-To: <1377800397-5434-1-git-send-email-felipe.contreras@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Signed-off-by: Felipe Contreras --- Documentation/git-reset.txt | 8 ++++++++ builtin/reset.c | 20 ++++++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/Documentation/git-reset.txt b/Documentation/git-reset.txt index f445cb3..5cd75a8 100644 --- a/Documentation/git-reset.txt +++ b/Documentation/git-reset.txt @@ -11,6 +11,7 @@ SYNOPSIS 'git reset' [-q] [] [--] ... 'git reset' (--patch | -p) [] [--] [...] 'git reset' [--soft | --mixed | --hard | --merge | --keep] [-q] [] +'git reset' [--stage | --work] [-q] [] DESCRIPTION ----------- @@ -81,6 +82,13 @@ but carries forward unmerged index entries. different between and HEAD. If a file that is different between and HEAD has local changes, reset is aborted. + +--stage:: + Reset the index, basically `--mixed`. `--no-stage` is the equivalent of + `--soft`. + +--work:: + Resets the working tree, basically `--hard`. -- If you want to undo a commit other than the latest on a branch, diff --git a/builtin/reset.c b/builtin/reset.c index afa6e02..fbc1abc 100644 --- a/builtin/reset.c +++ b/builtin/reset.c @@ -23,6 +23,7 @@ static const char * const git_reset_usage[] = { N_("git reset [--mixed | --soft | --hard | --merge | --keep] [-q] []"), + N_("git reset [--stage | --work] [-q] []"), N_("git reset [-q] [--] ..."), N_("git reset --patch [] [--] [...]"), NULL @@ -243,6 +244,7 @@ static int update_refs(const char *rev, const unsigned char *sha1) int cmd_reset(int argc, const char **argv, const char *prefix) { int reset_type = NONE, update_ref_status = 0, quiet = 0; + int stage = -1, working_tree = -1; int patch_mode = 0, unborn; const char *rev; unsigned char sha1[20]; @@ -258,6 +260,8 @@ int cmd_reset(int argc, const char **argv, const char *prefix) N_("reset HEAD, index and working tree"), MERGE), OPT_SET_INT(0, "keep", &reset_type, N_("reset HEAD but keep local changes"), KEEP), + OPT_BOOL(0, "stage", &stage, N_("reset index")), + OPT_BOOL(0, "work", &working_tree, N_("reset working tree")), OPT_BOOLEAN('p', "patch", &patch_mode, N_("select hunks interactively")), OPT_END() }; @@ -290,6 +294,22 @@ int cmd_reset(int argc, const char **argv, const char *prefix) hashcpy(sha1, tree->object.sha1); } + if (stage >= 0 || working_tree >= 0) { + if (reset_type != NONE) + die(_("--{stage,work} are incompatible with --{hard,mixed,soft,merge}")); + + if (working_tree == 1) { + if (stage == 0) + die(_("--no-stage doesn't make sense with --work")); + reset_type = HARD; + } else { + if (stage == 1) + reset_type = NONE; + else + reset_type = SOFT; + } + } + if (patch_mode) { if (reset_type != NONE) die(_("--patch is incompatible with --{hard,mixed,soft}")); -- 1.8.4-fc