git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hiroshige Umino <hiroshige88@gmail.com>
To: git@vger.kernel.org
Cc: Hiroshige Umino <hiroshige88@gmail.com>
Subject: [PATCH v2] cherry-pick: allow "-" as abbreviation of '@{-1}'
Date: Thu,  5 Sep 2013 23:57:23 +0900	[thread overview]
Message-ID: <1378393043-55403-1-git-send-email-hiroshige88@gmail.com> (raw)

"-" abbreviation is handy for "cherry-pick" like "checkout" and "merge".

It's also good for uniformity that a "-" stands as
the name of the previous branch where a branch name is
accepted and it could not mean any other things like stdin.

Signed-off-by: Hiroshige Umino <hiroshige88@gmail.com>
---
 builtin/revert.c  |  2 ++
 t/t3500-cherry.sh | 15 +++++++++++++++
 2 files changed, 17 insertions(+)

diff --git a/builtin/revert.c b/builtin/revert.c
index 8e87acd..52c35e7 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -202,6 +202,8 @@ int cmd_cherry_pick(int argc, const char **argv, const char *prefix)
 	memset(&opts, 0, sizeof(opts));
 	opts.action = REPLAY_PICK;
 	git_config(git_default_config, NULL);
+	if (!strcmp(argv[1], "-"))
+		argv[1] = "@{-1}";
 	parse_args(argc, argv, &opts);
 	res = sequencer_pick_revisions(&opts);
 	if (res < 0)
diff --git a/t/t3500-cherry.sh b/t/t3500-cherry.sh
index f038f34..547dbf8 100755
--- a/t/t3500-cherry.sh
+++ b/t/t3500-cherry.sh
@@ -55,4 +55,19 @@ test_expect_success \
      expr "$(echo $(git cherry master my-topic-branch) )" : "+ [^ ]* - .*"
 '
 
+test_expect_success \
+    '"cherry-pick -" does not work initially' \
+    'test_must_fail git cherry-pick -
+'
+
+test_expect_success \
+    'cherry-pick the commit in the previous branch' \
+    'git branch other &&
+     test_commit commit-to-pick newfile content &&
+     echo content >expected &&
+     git checkout other &&
+     git cherry-pick - &&
+     test_cmp expected newfile
+'
+
 test_done
-- 
1.8.3.4

             reply	other threads:[~2013-09-05 14:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 14:57 Hiroshige Umino [this message]
2013-09-05 22:30 ` [PATCH v2] cherry-pick: allow "-" as abbreviation of '@{-1}' Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378393043-55403-1-git-send-email-hiroshige88@gmail.com \
    --to=hiroshige88@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).