git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH/RFC] Developer's Certificate of Origin:  default to COPYING
@ 2013-09-12 22:11 Richard Hansen
  2013-09-12 22:30 ` Junio C Hamano
  0 siblings, 1 reply; 7+ messages in thread
From: Richard Hansen @ 2013-09-12 22:11 UTC (permalink / raw)
  To: git, gitster; +Cc: Richard Hansen

The "Developer's Certificate of Origin" refers to "the open source
license indicated in the file", but there is no such indication in
most files in the Git repository.

Update the text to indicate that the license in COPYING should be
assumed if a file doesn't excplicitly indicate which license applies
to the file.

The phrase "accompanies the file" was chosen to support different
default licenses in different subdirectories (e.g., 2-clause BSD for
vcs-svn/*, LGPL2.1+ for xdiff/*).

Signed-off-by: Richard Hansen <rhansen@bbn.com>
---
I'm bringing this up because, to this layman's eyes, it seems like a
potentially troublesome oversight.  IIUC, one of the purposes of the
Developer's Certificate of Origin is to make it easy for developers to
declare which license covers a contribution.  Requiring a license
declaration protects the project and its users from copyright
litigation.

What happens if the file(s) being modified do not indicate which
license applies to the file?  Is there no license?  Does it default to
the main project license in COPYING?  This lack of clarity makes me a
bit nervous (law is already too nondeterministic for my liking), so
I'd like to see a change that makes it explicit.

Notes:
  * I am not a lawyer.  (Maybe a lawyer should be consulted?)
  * This change might not be necessary.
  * This change might be wrong.
  * I hope I'm not just wasting everyone's time by bringing this up.

 Documentation/SubmittingPatches | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 7055576..c5ff744 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -227,13 +227,15 @@ the patch, which certifies that you wrote it or otherwise have
 the right to pass it on as a open-source patch.  The rules are
 pretty simple: if you can certify the below:
 
-        Developer's Certificate of Origin 1.1
+        Developer's Certificate of Origin 1.2
 
         By making a contribution to this project, I certify that:
 
         (a) The contribution was created in whole or in part by me and I
             have the right to submit it under the open source license
-            indicated in the file; or
+            indicated in the file (or, if no license is indicated in
+            the file, the license in COPYING that accompanies the
+            file); or
 
         (b) The contribution is based upon previous work that, to the best
             of my knowledge, is covered under an appropriate open source
@@ -241,7 +243,8 @@ pretty simple: if you can certify the below:
             work with modifications, whether created in whole or in part
             by me, under the same open source license (unless I am
             permitted to submit under a different license), as indicated
-            in the file; or
+            in the file (or, if no license is indicated in the file,
+            the license in COPYING that accompanies the file); or
 
         (c) The contribution was provided directly to me by some other
             person who certified (a), (b) or (c) and I have not modified
-- 
1.8.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH/RFC] Developer's Certificate of Origin:  default to COPYING
  2013-09-12 22:11 [PATCH/RFC] Developer's Certificate of Origin: default to COPYING Richard Hansen
@ 2013-09-12 22:30 ` Junio C Hamano
  2013-09-12 22:44   ` Linus Torvalds
  0 siblings, 1 reply; 7+ messages in thread
From: Junio C Hamano @ 2013-09-12 22:30 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: git, Richard Hansen

Linus, this is not limited to us, so I am bothering you; sorry about
that.

My instinct tells me that some competent lawyers at linux-foundation
helped you with the wording of DCO, and we amateurs shouldn't be
mucking with the text like this patch does at all, but just in case
you might find it interesting...


Richard Hansen <rhansen@bbn.com> writes:

> The "Developer's Certificate of Origin" refers to "the open source
> license indicated in the file", but there is no such indication in
> most files in the Git repository.
>
> Update the text to indicate that the license in COPYING should be
> assumed if a file doesn't excplicitly indicate which license applies
> to the file.
>
> The phrase "accompanies the file" was chosen to support different
> default licenses in different subdirectories (e.g., 2-clause BSD for
> vcs-svn/*, LGPL2.1+ for xdiff/*).
>
> Signed-off-by: Richard Hansen <rhansen@bbn.com>
> ---
> I'm bringing this up because, to this layman's eyes, it seems like a
> potentially troublesome oversight.  IIUC, one of the purposes of the
> Developer's Certificate of Origin is to make it easy for developers to
> declare which license covers a contribution.  Requiring a license
> declaration protects the project and its users from copyright
> litigation.
>
> What happens if the file(s) being modified do not indicate which
> license applies to the file?  Is there no license?  Does it default to
> the main project license in COPYING?  This lack of clarity makes me a
> bit nervous (law is already too nondeterministic for my liking), so
> I'd like to see a change that makes it explicit.
>
> Notes:
>   * I am not a lawyer.  (Maybe a lawyer should be consulted?)
>   * This change might not be necessary.
>   * This change might be wrong.
>   * I hope I'm not just wasting everyone's time by bringing this up.
>
>  Documentation/SubmittingPatches | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 7055576..c5ff744 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -227,13 +227,15 @@ the patch, which certifies that you wrote it or otherwise have
>  the right to pass it on as a open-source patch.  The rules are
>  pretty simple: if you can certify the below:
>  
> -        Developer's Certificate of Origin 1.1
> +        Developer's Certificate of Origin 1.2
>  
>          By making a contribution to this project, I certify that:
>  
>          (a) The contribution was created in whole or in part by me and I
>              have the right to submit it under the open source license
> -            indicated in the file; or
> +            indicated in the file (or, if no license is indicated in
> +            the file, the license in COPYING that accompanies the
> +            file); or
>  
>          (b) The contribution is based upon previous work that, to the best
>              of my knowledge, is covered under an appropriate open source
> @@ -241,7 +243,8 @@ pretty simple: if you can certify the below:
>              work with modifications, whether created in whole or in part
>              by me, under the same open source license (unless I am
>              permitted to submit under a different license), as indicated
> -            in the file; or
> +            in the file (or, if no license is indicated in the file,
> +            the license in COPYING that accompanies the file); or
>  
>          (c) The contribution was provided directly to me by some other
>              person who certified (a), (b) or (c) and I have not modified

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH/RFC] Developer's Certificate of Origin: default to COPYING
  2013-09-12 22:30 ` Junio C Hamano
@ 2013-09-12 22:44   ` Linus Torvalds
  2013-09-12 23:15     ` Richard Hansen
  0 siblings, 1 reply; 7+ messages in thread
From: Linus Torvalds @ 2013-09-12 22:44 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Git Mailing List, Richard Hansen

On Thu, Sep 12, 2013 at 3:30 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Linus, this is not limited to us, so I am bothering you; sorry about
> that.
>
> My instinct tells me that some competent lawyers at linux-foundation
> helped you with the wording of DCO, and we amateurs shouldn't be
> mucking with the text like this patch does at all, but just in case
> you might find it interesting...

There were lawyers involved, yes.

I'm not sure there is any actual confusion, because the fact is,
lawyers aren't robots or programmers, and they have the human
qualities of understanding implications. So I'm actually inclined to
not change legal text unless a lawyer actually tells me that it's
needed.

Plus even if this change was needed, why would anybody point to
"COPYING". It's much better to just say "the copyright license of the
file", knowing that different projects have different rules about this
all, and some projects mix files from different sources, where parts
of the tree may be under different licenses that may be explained
elsewhere..

            Linus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH/RFC] Developer's Certificate of Origin: default to COPYING
  2013-09-12 22:44   ` Linus Torvalds
@ 2013-09-12 23:15     ` Richard Hansen
  2013-09-12 23:24       ` Theodore Ts'o
  2013-09-12 23:25       ` Linus Torvalds
  0 siblings, 2 replies; 7+ messages in thread
From: Richard Hansen @ 2013-09-12 23:15 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Junio C Hamano, Git Mailing List

On 2013-09-12 18:44, Linus Torvalds wrote:
> On Thu, Sep 12, 2013 at 3:30 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Linus, this is not limited to us, so I am bothering you; sorry about
>> that.
>>
>> My instinct tells me that some competent lawyers at linux-foundation
>> helped you with the wording of DCO, and we amateurs shouldn't be
>> mucking with the text like this patch does at all, but just in case
>> you might find it interesting...
> 
> There were lawyers involved, yes.
> 
> I'm not sure there is any actual confusion, because the fact is,
> lawyers aren't robots or programmers, and they have the human
> qualities of understanding implications.

Well stated.  :)

> So I'm actually inclined to
> not change legal text unless a lawyer actually tells me that it's
> needed.

Is it worthwhile to poke a lawyer about this as a precaution?  (If so,
who?)  Or do we wait for a motivating event?

> 
> Plus even if this change was needed, why would anybody point to
> "COPYING". It's much better to just say "the copyright license of the
> file", knowing that different projects have different rules about this
> all, and some projects mix files from different sources, where parts
> of the tree may be under different licenses that may be explained
> elsewhere..

I agree that your phrasing is better.

-Richard

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH/RFC] Developer's Certificate of Origin: default to COPYING
  2013-09-12 23:15     ` Richard Hansen
@ 2013-09-12 23:24       ` Theodore Ts'o
  2013-09-12 23:25       ` Linus Torvalds
  1 sibling, 0 replies; 7+ messages in thread
From: Theodore Ts'o @ 2013-09-12 23:24 UTC (permalink / raw)
  To: Richard Hansen; +Cc: Linus Torvalds, Junio C Hamano, Git Mailing List

I certainly wouldn't recommend messing with the text of the DCO
without first consulting some lawyers.  There should also be some
centralized coordination about any changes in the text and the version
number.

						- Ted

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH/RFC] Developer's Certificate of Origin: default to COPYING
  2013-09-12 23:15     ` Richard Hansen
  2013-09-12 23:24       ` Theodore Ts'o
@ 2013-09-12 23:25       ` Linus Torvalds
  2013-09-13  1:18         ` W. Trevor King
  1 sibling, 1 reply; 7+ messages in thread
From: Linus Torvalds @ 2013-09-12 23:25 UTC (permalink / raw)
  To: Richard Hansen; +Cc: Junio C Hamano, Git Mailing List

On Thu, Sep 12, 2013 at 4:15 PM, Richard Hansen <rhansen@bbn.com> wrote:
>
> Is it worthwhile to poke a lawyer about this as a precaution?  (If so,
> who?)  Or do we wait for a motivating event?

I can poke the lawyer that was originally involved. If people know
other lawyers, feel free to poke them too. Just ask them to be
realistic, not go into some kind of super-anal lawyer mode where they
go off on some "what if" thing.

Note that one issue is that this is kind of like a license change,
even if it's arguably just a clarification. I'd expect that a lawyer
who is so anal that they think this wording needs change would also
think that the DCO version number needs change and then spend half an
hour (and $500) talking about how this only affects new sign-offs and
how you'd want to make it very obvious how things have changed, Yadda
yadda.

IOW, my personal opinion is that if you get a lawyer that is _that_
interested in irrelevant details, you have much bigger problems than
this particular wording. Lawyers do tend to be particular about
wording, but in the end, they tend to also agree that intent matters.
At least the good ones who have a case. Once they start talking about
the "meaning of the word 'is'", you know they are just weaselwording
and don't actually have any real argument.

              Linus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH/RFC] Developer's Certificate of Origin: default to COPYING
  2013-09-12 23:25       ` Linus Torvalds
@ 2013-09-13  1:18         ` W. Trevor King
  0 siblings, 0 replies; 7+ messages in thread
From: W. Trevor King @ 2013-09-13  1:18 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Git Mailing List, Bradley M. Kuhn, Luis R. Rodriguez,
	Richard Fontana, Mike Dolan, Copenhaver, Karen

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

On Thu, Sep 12, 2013 at 04:25:03PM -0700, Linus Torvalds wrote:
> On Thu, Sep 12, 2013 at 4:15 PM, Richard Hansen <rhansen@bbn.com> wrote:
> >
> > Is it worthwhile to poke a lawyer about this as a precaution?  (If so,
> > who?)  Or do we wait for a motivating event?
> 
> I can poke the lawyer that was originally involved.

For what it's worth, there is an existing push to clarify the
licensing terms for the DCO [1].  Involved parties include Luis
Rodriguez, Richard Fontana, Bradley Kuhn, Mike Dolan, and Karen
Copenhaver.  Hopefully they'll have something to say after the New
Orleans LinuxCon.  The DCO licensing is not quite the same as changing
the DCO text, but they're probably closely related ;).

Cheers,
Trevor

[1]: http://thread.gmane.org/gmane.linux.kernel/1397613/focus=1400065

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-09-13  1:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-12 22:11 [PATCH/RFC] Developer's Certificate of Origin: default to COPYING Richard Hansen
2013-09-12 22:30 ` Junio C Hamano
2013-09-12 22:44   ` Linus Torvalds
2013-09-12 23:15     ` Richard Hansen
2013-09-12 23:24       ` Theodore Ts'o
2013-09-12 23:25       ` Linus Torvalds
2013-09-13  1:18         ` W. Trevor King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).