From: Eric Sunshine <sunshine@sunshineco.com>
To: git@vger.kernel.org
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Brian Gernhardt <brian@gernhardtsoftware.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: [PATCH v2 0/4] stop storing trailing slash in dir-hash
Date: Tue, 17 Sep 2013 03:06:13 -0400 [thread overview]
Message-ID: <1379401577-36799-1-git-send-email-sunshine@sunshineco.com> (raw)
This series changes name-hash to stop storing the (redundant) trailing
slash with index_state.dir_hash entries. As an intentional side-effect,
the series fixes [1] in a cleaner way (suggested by Junio [2]) than
either [3] (680be044 in master) or [4].
Changes since v1 [5]:
* Add index_file_exists() as complement of index_dir_exists() introduced
in v1 rather than changing the behavior of index_name_exists() to
check only for files. To avoid disturbing current or future in-flight
topics, index_name_exists() is retained (suggested by Junio [6]) as a
thin wrapper dispatching either to index_file_exists() or
index_dir_exists().
* Split v1 patch 1 into v2 patches 1 & 2 to ease review. (This is
possible now that index_name_exists() retains its original behavior.)
[1]: http://thread.gmane.org/gmane.comp.version-control.git/232727
[2]: http://thread.gmane.org/gmane.comp.version-control.git/232727/focus=232813
[3]: http://thread.gmane.org/gmane.comp.version-control.git/232796
[4]: http://thread.gmane.org/gmane.comp.version-control.git/232833
[5]: http://thread.gmane.org/gmane.comp.version-control.git/234743
[6]: http://article.gmane.org/gmane.comp.version-control.git/234761
Eric Sunshine (4):
name-hash: refactor polymorphic index_name_exists()
employ new explicit "exists in index?" API
name-hash: stop storing trailing '/' on paths in index_state.dir_hash
dir: revert work-around for retired dangerous behavior
cache.h | 4 ++++
dir.c | 28 ++++++++-------------------
name-hash.c | 61 ++++++++++++++++++++++++++++++++--------------------------
read-cache.c | 4 ++--
unpack-trees.c | 4 ++--
5 files changed, 50 insertions(+), 51 deletions(-)
--
1.8.4.535.g7b94f8e
next reply other threads:[~2013-09-17 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 7:06 Eric Sunshine [this message]
2013-09-17 7:06 ` [PATCH v2 1/4] name-hash: refactor polymorphic index_name_exists() Eric Sunshine
2013-09-17 7:06 ` [PATCH v2 2/4] employ new explicit "exists in index?" API Eric Sunshine
2013-09-17 7:06 ` [PATCH v2 3/4] name-hash: stop storing trailing '/' on paths in index_state.dir_hash Eric Sunshine
2013-09-17 7:06 ` [PATCH v2 4/4] dir: revert work-around for retired dangerous behavior Eric Sunshine
2013-09-17 17:11 ` [PATCH v2 0/4] stop storing trailing slash in dir-hash Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379401577-36799-1-git-send-email-sunshine@sunshineco.com \
--to=sunshine@sunshineco.com \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).