From: "Carlos Martín Nieto" <cmn@elego.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Duy Nguyen <pclouds@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it
Date: Sat, 19 Oct 2013 17:19:47 +0200 [thread overview]
Message-ID: <1382195987.17156.7.camel@centaur.cmartin.tk> (raw)
In-Reply-To: <20131008222215.GI9464@google.com>
On Tue, 2013-10-08 at 15:22 -0700, Jonathan Nieder wrote:
> Duy Nguyen wrote:
>
> > Or maybe it's not that late. How about you go with your patch and add
> > thin-pack capability to receive-pack too?
> >
> > When new "git push" is used against old server, thin pack is disabled.
> > But that's not a big deal (I hope).
>
> Could we have separate patches to introduce the server-side capability
> and then to request it in the client? That way, people with old
> servers can apply the patch introducing the capability if they want.
That could work.
>
> The new meaning of the "thin-pack" capability should also be
> documented in Documentation/technical/protocol-capabilities.txt.
Oh, right; the capability as described is only about the server being
able to generate a thin pack. Wouldn't his mean that git shouldn't
assume that *any* remote can fix thin packs, though? (other than most
servers you do talk to happen to).
Anyway, facts on the ground and all that. I'll prepare some
>
> Done that way and with enough time between the server advertising the
> capability and the client looking for it, it seems like a good idea.
If such patches would be accepted, that would be great. By the time this
all gets merged, we might have thin pack fixing merged into libgit2, but
there will still be uses where fixing them isn't an issue due to other
constraints.
Cheers,
cmn
prev parent reply other threads:[~2013-10-19 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 8:44 [PATCH] send-pack: don't send a thin pack when the server doesn't support it Carlos Martín Nieto
2013-10-08 9:44 ` Duy Nguyen
2013-10-08 10:58 ` Carlos Martin Nieto
2013-10-08 11:29 ` Duy Nguyen
2013-10-08 22:22 ` Jonathan Nieder
2013-10-19 15:19 ` Carlos Martín Nieto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382195987.17156.7.camel@centaur.cmartin.tk \
--to=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).