From: "Jens Lindström" <jl@opera.com>
To: git@vger.kernel.org
Cc: Duy Nguyen <pclouds@gmail.com>
Subject: [PATCH] Clear fd after closing to avoid double-close error
Date: Tue, 22 Oct 2013 14:10:23 +0200 [thread overview]
Message-ID: <1382443823-31317-1-git-send-email-jl@opera.com> (raw)
From: Jens Lindstrom <jl@opera.com>
In send_pack(), clear the fd passed to pack_objects() by setting
it to -1, since pack_objects() closes the fd (via a call to
run_command()).
Not doing so risks having git_transport_push(), caller of
send_pack(), closing the fd again, possibly incorrectly closing
some other open file.
Signed-off-by: Jens Lindström <jl@opera.com>
---
send-pack.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/send-pack.c b/send-pack.c
index 7d172ef..7def2af 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -302,6 +302,9 @@ int send_pack(struct send_pack_args *args,
finish_async(&demux);
return -1;
}
+ if (!args->stateless_rpc)
+ /* Closed by pack_objects() via start_command() */
+ fd[1] = -1;
}
if (args->stateless_rpc && cmds_sent)
packet_flush(out);
--
1.8.1.2
next reply other threads:[~2013-10-22 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 12:10 Jens Lindström [this message]
2013-10-22 12:39 ` [PATCH] Clear fd after closing to avoid double-close error Duy Nguyen
2013-10-22 13:15 ` Jens Lindström
2013-10-22 18:42 ` Junio C Hamano
2013-10-23 7:52 ` Jens Lindström
2013-10-23 16:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382443823-31317-1-git-send-email-jl@opera.com \
--to=jl@opera.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).