From: james.moger@gitblit.com
To: Johannes Sixt <j.sixt@viscovery.net>,
Duy Nguyen <pclouds@gmail.com>,
Nasser Grainawi <nasser@codeaurora.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Martin Fick <mfick@codeaurora.org>, Thomas Koch <thomas@koch.ro>,
Jeremy Rosen <jeremy.rosen@openwide.fr>,
Git Mailing List <git@vger.kernel.org>,
Shawn Pearce <spearce@spearce.org>
Subject: Re: RFE: support change-id generation natively
Date: Thu, 24 Oct 2013 08:11:05 -0400 [thread overview]
Message-ID: <1382616665.23343.37953397.70FB76CB@webmail.messagingengine.com> (raw)
In-Reply-To: <5268B7D6.5050106@viscovery.net>
> That said, I don't think that --change-id option that the user must not
> forget to use is any better than a hook that the user must not forget to
> install.
Having a --change-id option, to my mind, simplifies use of the patch
workflow as it does not require downloading, copying and setting
executable a hook script per-repository or globally. I agree that
forgetting to add it on the command-line is a potential problem. This
could be improved by honoring the "gerrit.createchangeid" value (or
whatever setting name is appropriate). Of course that still requires
configuring the repo after clone, but it's clean and straight-forward
since it is all plain "git config".
-J
next prev parent reply other threads:[~2013-10-24 12:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 14:48 RFE: support change-id generation natively james.moger
2013-10-21 14:51 ` Jeremy Rosen
2013-10-21 15:41 ` james.moger
2013-10-21 16:35 ` Shawn Pearce
2013-10-21 16:38 ` Ondřej Bílka
2013-10-21 23:07 ` Shawn Pearce
2013-10-21 18:29 ` Thomas Koch
2013-10-21 18:40 ` james.moger
2013-10-21 18:49 ` Martin Fick
2013-10-22 19:50 ` Junio C Hamano
2013-10-22 20:06 ` Pyeron, Jason J CTR (US)
2013-10-22 20:43 ` Junio C Hamano
2013-10-23 6:36 ` Duy Nguyen
2013-10-23 16:00 ` Junio C Hamano
2013-10-24 2:07 ` Duy Nguyen
2013-10-24 4:11 ` Nasser Grainawi
2013-10-24 5:25 ` Duy Nguyen
2013-10-24 6:01 ` Johannes Sixt
2013-10-24 12:11 ` james.moger [this message]
2013-10-24 12:51 ` Thomas Koch
2013-10-24 13:31 ` Duy Nguyen
2013-10-24 20:04 ` Junio C Hamano
2013-10-25 6:37 ` Johannes Sixt
2013-10-21 23:10 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382616665.23343.37953397.70FB76CB@webmail.messagingengine.com \
--to=james.moger@gitblit.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jeremy.rosen@openwide.fr \
--cc=mfick@codeaurora.org \
--cc=nasser@codeaurora.org \
--cc=pclouds@gmail.com \
--cc=spearce@spearce.org \
--cc=thomas@koch.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).