git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Cornu <ncornu@aldebaran-robotics.com>
To: git@vger.kernel.org
Cc: paulus@samba.org
Subject: [PATCH v2] gitk: Add a horizontal scrollbar for commit history
Date: Wed, 30 Oct 2013 11:58:22 +0100	[thread overview]
Message-ID: <1383130702-4966-1-git-send-email-ncornu@aldebaran-robotics.com> (raw)

This scrollbar is not optional and is useful if there is a lot of tags or
branches.

Signed-off-by: Nicolas Cornu <ncornu@aldebaran-robotics.com>
---
 gitk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gitk b/gitk
index 5cd00d8..62563b1 100755
--- a/gitk
+++ b/gitk
@@ -2120,11 +2120,17 @@ proc makewindow {} {
     # create three canvases
     set cscroll .tf.histframe.csb
     set canv .tf.histframe.pwclist.canv
+    set cscrollhl .tf.histframe.pwclist.canv.csb
     canvas $canv \
 	-selectbackground $selectbgcolor \
 	-background $bgcolor -bd 0 \
-	-yscrollincr $linespc -yscrollcommand "scrollcanv $cscroll"
+	-yscrollincr $linespc -yscrollcommand "scrollcanv $cscroll" \
+	-xscrollcommand "scrollcanv $cscrollhl"
     .tf.histframe.pwclist add $canv
+    ${NS}::scrollbar $cscrollhl -command {$canv xview} -orient horizontal
+    if {!$use_ttk} {$cscrollhl configure -highlightthickness 0}
+    pack $cscrollhl -fill x -side bottom
+
     set canv2 .tf.histframe.pwclist.canv2
     canvas $canv2 \
 	-selectbackground $selectbgcolor \
--
1.8.4.2

             reply	other threads:[~2013-10-30 10:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30 10:58 Nicolas Cornu [this message]
2013-10-30 12:01 ` [PATCH v2] gitk: Add a horizontal scrollbar for commit history Johannes Sixt
2013-10-30 12:47   ` Nicolas Cornu
2013-10-30 14:46     ` Marc Branchaud
2013-10-30 14:49       ` Nicolas Cornu
2013-10-30 15:04         ` Marc Branchaud
2013-10-31  9:05     ` Paul Mackerras
2013-11-02  9:40       ` Heiko Voigt
2013-11-04 15:50       ` Marc Branchaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383130702-4966-1-git-send-email-ncornu@aldebaran-robotics.com \
    --to=ncornu@aldebaran-robotics.com \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).