From: Richard Hansen <rhansen@bbn.com>
To: git@vger.kernel.org
Cc: felipe.contreras@gmail.com, srabbelier@gmail.com,
Richard Hansen <rhansen@bbn.com>
Subject: [PATCH v5 12/10] remote-bzr: support the new 'force' option
Date: Mon, 11 Nov 2013 00:10:56 -0500 [thread overview]
Message-ID: <1384146656-11811-1-git-send-email-rhansen@bbn.com> (raw)
In-Reply-To: <1383212197-14259-2-git-send-email-felipe.contreras@gmail.com>
Signed-off-by: Richard Hansen <rhansen@bbn.com>
---
contrib/remote-helpers/git-remote-bzr | 34 +++++++++++++++++++++++++++++++++-
contrib/remote-helpers/test-bzr.sh | 22 +++++++++++++++++++++-
2 files changed, 54 insertions(+), 2 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index 7e34532..ba693d1 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -42,6 +42,7 @@ import json
import re
import StringIO
import atexit, shutil, hashlib, urlparse, subprocess
+import types
NAME_RE = re.compile('^([^<>]+)')
AUTHOR_RE = re.compile('^([^<>]+?)? ?[<>]([^<>]*)(?:$|>)')
@@ -684,7 +685,8 @@ def do_export(parser):
peer = bzrlib.branch.Branch.open(peers[name],
possible_transports=transports)
try:
- peer.bzrdir.push_branch(branch, revision_id=revid)
+ peer.bzrdir.push_branch(branch, revision_id=revid,
+ overwrite=force)
except bzrlib.errors.DivergedBranches:
print "error %s non-fast forward" % ref
continue
@@ -718,8 +720,34 @@ def do_capabilities(parser):
print "*import-marks %s" % path
print "*export-marks %s" % path
+ print "option"
print
+class InvalidOptionValue(Exception):
+ pass
+
+def do_option(parser):
+ (opt, val) = parser[1:3]
+ handler = globals().get('do_option_' + opt)
+ if handler and type(handler) == types.FunctionType:
+ try:
+ handler(val)
+ except InvalidOptionValue:
+ print "error '%s' is not a valid value for option '%s'" % (val, opt)
+ else:
+ print "unsupported"
+
+def do_bool_option(val):
+ if val == 'true': ret = True
+ elif val == 'false': ret = False
+ else: raise InvalidOptionValue()
+ print "ok"
+ return ret
+
+def do_option_force(val):
+ global force
+ force = do_bool_option(val)
+
def ref_is_valid(name):
return not True in [c in name for c in '~^: \\']
@@ -882,6 +910,7 @@ def main(args):
global is_tmp
global branches, peers
global transports
+ global force
alias = args[1]
url = args[2]
@@ -895,6 +924,7 @@ def main(args):
branches = {}
peers = {}
transports = []
+ force = False
if alias[5:] == url:
is_tmp = True
@@ -930,6 +960,8 @@ def main(args):
do_import(parser)
elif parser.check('export'):
do_export(parser)
+ elif parser.check('option'):
+ do_option(parser)
else:
die('unhandled command: %s' % line)
sys.stdout.flush()
diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh
index ea597b0..7d7778f 100755
--- a/contrib/remote-helpers/test-bzr.sh
+++ b/contrib/remote-helpers/test-bzr.sh
@@ -69,13 +69,33 @@ test_expect_success 'pushing' '
test_cmp expected actual
'
+test_expect_success 'forced pushing' '
+ (
+ cd gitrepo &&
+ echo three-new >content &&
+ git commit -a --amend -m three-new &&
+ git push -f
+ ) &&
+
+ (
+ cd bzrrepo &&
+ # the forced update overwrites the bzr branch but not the bzr
+ # working directory (it tries to merge instead)
+ bzr revert
+ ) &&
+
+ echo three-new >expected &&
+ cat bzrrepo/content >actual &&
+ test_cmp expected actual
+'
+
test_expect_success 'roundtrip' '
(
cd gitrepo &&
git pull &&
git log --format="%s" -1 origin/master >actual
) &&
- echo three >expected &&
+ echo three-new >expected &&
test_cmp expected actual &&
(cd gitrepo && git push && git pull) &&
--
1.8.5.rc1.207.gc17dd22
next prev parent reply other threads:[~2013-11-11 5:11 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 9:36 [PATCH v5 10/10] transport-helper: add support to delete branches Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 00/10] transport-helper: updates Felipe Contreras
2013-10-31 17:59 ` Max Horn
2013-10-31 18:10 ` Junio C Hamano
2013-10-31 18:30 ` Felipe Contreras
2013-10-31 18:34 ` Junio C Hamano
2013-10-31 18:41 ` Max Horn
2013-11-11 5:09 ` [PATCH v5 11/10] test-hg.sh: tests are now expected to pass Richard Hansen
2013-11-11 5:10 ` Richard Hansen [this message]
2013-11-11 11:51 ` [PATCH v5 12/10] remote-bzr: support the new 'force' option Felipe Contreras
2013-11-11 18:12 ` Richard Hansen
2013-11-11 18:15 ` Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 01/10] transport-helper: fix extra lines Felipe Contreras
2013-10-31 18:16 ` Junio C Hamano
2013-10-31 9:36 ` [PATCH v5 08/10] fast-import: add support to delete refs Felipe Contreras
2013-10-31 18:41 ` Max Horn
2013-10-31 9:36 ` [PATCH v5 05/10] fast-export: improve argument parsing Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 06/10] fast-export: add new --refspec option Felipe Contreras
2013-10-31 18:26 ` Junio C Hamano
2013-10-31 18:41 ` Felipe Contreras
2013-11-06 21:00 ` Junio C Hamano
2013-11-06 22:14 ` Jeff King
2013-11-06 22:31 ` Junio C Hamano
2013-11-06 22:41 ` Junio C Hamano
2013-11-08 23:44 ` Junio C Hamano
2013-11-09 0:06 ` Jeff King
2013-11-07 1:00 ` Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers Felipe Contreras
2013-10-31 18:21 ` Junio C Hamano
2013-10-31 18:55 ` Felipe Contreras
2013-10-31 19:07 ` Junio C Hamano
2013-11-01 14:49 ` Junio C Hamano
2013-11-01 15:37 ` Felipe Contreras
2013-11-01 16:35 ` Junio C Hamano
2013-11-01 17:28 ` Eric Sunshine
2013-11-11 5:01 ` [PATCH] fixup! " Richard Hansen
2013-10-31 9:36 ` [PATCH v5 09/10] fast-export: add support to delete refs Felipe Contreras
2013-10-31 19:29 ` Max Horn
2013-10-31 19:41 ` Felipe Contreras
2013-10-31 19:47 ` Max Horn
2013-10-31 19:53 ` Felipe Contreras
2013-10-31 22:38 ` Max Horn
2013-10-31 9:36 ` [PATCH v5 07/10] transport-helper: add support for old:new refspec Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 04/10] transport-helper: check for 'forced update' message Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 02/10] transport-helper: don't update refs in dry-run Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384146656-11811-1-git-send-email-rhansen@bbn.com \
--to=rhansen@bbn.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).