From: Krzesimir Nowak <krzesimir@endocode.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, jnareb@gmail.com, sunshine@sunshineco.com,
Krzesimir Nowak <krzesimir@endocode.com>
Subject: [PATCH v7 1/4] gitweb: Move check-ref-format code into separate function
Date: Wed, 11 Dec 2013 12:54:41 +0100 [thread overview]
Message-ID: <1386762884-7564-2-git-send-email-krzesimir@endocode.com> (raw)
In-Reply-To: <1386762884-7564-1-git-send-email-krzesimir@endocode.com>
This check will be used in more than one place later.
Signed-off-by: Krzesimir Nowak <krzesimir@endocode.com>
---
gitweb/gitweb.perl | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 68c77f6..46bd6ac 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1452,6 +1452,16 @@ sub validate_pathname {
return $input;
}
+sub is_valid_ref_format {
+ my $input = shift || return undef;
+
+ # restrictions on ref name according to git-check-ref-format
+ if ($input =~ m!(/\.|\.\.|[\000-\040\177 ~^:?*\[]|/$)!) {
+ return undef;
+ }
+ return $input;
+}
+
sub validate_refname {
my $input = shift || return undef;
@@ -1462,10 +1472,9 @@ sub validate_refname {
# it must be correct pathname
$input = validate_pathname($input)
or return undef;
- # restrictions on ref name according to git-check-ref-format
- if ($input =~ m!(/\.|\.\.|[\000-\040\177 ~^:?*\[]|/$)!) {
- return undef;
- }
+ # check git-check-ref-format restrictions
+ is_valid_ref_format($input)
+ or return undef;
return $input;
}
--
1.8.3.1
next prev parent reply other threads:[~2013-12-11 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 11:54 [PATCH v7 0/4] Show extra branch refs in gitweb Krzesimir Nowak
2013-12-11 11:54 ` Krzesimir Nowak [this message]
2013-12-11 11:54 ` [PATCH v7 2/4] gitweb: Return 1 on validation success instead of passed input Krzesimir Nowak
2013-12-11 16:08 ` Jakub Narębski
2013-12-11 11:54 ` [PATCH v7 3/4] gitweb: Add a feature for adding more branch refs Krzesimir Nowak
2013-12-11 11:54 ` [PATCH v7 4/4] gitweb: Denote non-heads, non-remotes branches Krzesimir Nowak
2013-12-12 21:46 ` [PATCH v7 0/4] Show extra branch refs in gitweb Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386762884-7564-2-git-send-email-krzesimir@endocode.com \
--to=krzesimir@endocode.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).