From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 2/4] completion: introduce __gitcomp_2 ()
Date: Fri, 3 Jan 2014 13:30:29 +0530 [thread overview]
Message-ID: <1388736031-6068-3-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1388736031-6068-1-git-send-email-artagnon@gmail.com>
There are situations where two classes of completions possible. For
example
branch.<TAB>
should try to complete
branch.master.
branch.autosetupmerge
branch.autosetuprebase
The first candidate has the suffix ".", and the second/ third candidates
have the suffix " ". To facilitate completions of this kind, create a
variation of __gitcomp_nl () that accepts two sets of arguments and two
independent suffixes.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
contrib/completion/git-completion.bash | 30 ++++++++++++++++++++++++++++++
contrib/completion/git-completion.zsh | 10 ++++++++++
2 files changed, 40 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 51c2dd4..64b20b8 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -233,6 +233,36 @@ __gitcomp_nl ()
__gitcompadd "$1" "${2-}" "${3-$cur}" "${4- }"
}
+# Generates completion reply from two sets of completion words, with
+# configurable suffixes for each.
+#
+# It accepts 2 to 6 arguments:
+# 1: First set of possible completion words.
+# 2: Second set of possible completion words.
+# 3: A prefix to be added to each completion word (both $1 and $2)
+# (optional).
+# 4: Generate possible completion matches for this word (optional).
+# 5: A suffix to be appended to each completion word in the first set
+# ($1) instead of the default space (optional).
+# 6: A suffix to be appended to each completion word in the second set
+# ($2) instead of the default space (optional).
+__gitcomp_2 ()
+{
+ local pfx="${3-}" cur_="${4-$cur}" sfx="${5- }" sfx2="${6- }" i=0
+ local IFS=$' \t\n'
+
+ for x in $1; do
+ if [[ "$x" == "$cur_"* ]]; then
+ COMPREPLY[i++]="$pfx$x$sfx"
+ fi
+ done
+ for x in $2; do
+ if [[ "$x" == "$cur_"* ]]; then
+ COMPREPLY[i++]="$pfx$x$sfx2"
+ fi
+ done
+}
+
# Generates completion reply with compgen from newline-separated possible
# completion filenames.
# It accepts 1 to 3 arguments:
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
index 6fca145..261a7f5 100644
--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -76,6 +76,16 @@ __gitcomp_nl ()
compadd -Q -S "${4- }" -p "${2-}" -- ${=1} && _ret=0
}
+__gitcomp_2 ()
+{
+ emulate -L zsh
+
+ local IFS=$' \t\n'
+ compset -P '*[=:]'
+ compadd -Q -S "${5- }" -p "${3-}" -- ${=1} && _ret=0
+ compadd -Q -S "${6- }" -p "${3-}" -- ${=2} && _ret=0
+}
+
__gitcomp_file ()
{
emulate -L zsh
--
1.8.5.2.227.g53f3478
next prev parent reply other threads:[~2014-01-03 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 8:00 [PATCH v2 0/4] Fix branch.autosetup(merge|rebase) completion Ramkumar Ramachandra
2014-01-03 8:00 ` [PATCH v2 1/4] completion: prioritize ./git-completion.bash Ramkumar Ramachandra
2014-01-03 22:55 ` brian m. carlson
2014-01-03 23:03 ` Junio C Hamano
2014-01-05 10:08 ` Ramkumar Ramachandra
2014-01-03 8:00 ` Ramkumar Ramachandra [this message]
2014-01-03 8:00 ` [PATCH v2 3/4] completion: fix branch.autosetup(merge|rebase) Ramkumar Ramachandra
2014-01-03 8:00 ` [PATCH v2 4/4] completion: fix remote.pushdefault Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388736031-6068-3-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).