From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Stefan Beller <stefanbeller@googlemail.com>,
Siddharth Agarwal <sid0@fb.com>
Subject: [PATCH v2 0/2] Fix "repack --window-memory=4g" regression in 1.8.4
Date: Wed, 22 Jan 2014 11:58:03 -0800 [thread overview]
Message-ID: <1390420685-18449-1-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <xmqqzjmprlbq.fsf@gitster.dls.corp.google.com>
The command line parser was broken when the command was
reimplemented in C in two ways. It incorrectly limited the value
range of window-memory and max-pack-size to "int", and also stopped
grokking the unit suffixes like 2g/400m/8k.
These two patches apply on top of 35c14176 (Reword repack
documentation to no longer state it's a script, 2013-10-19) and
later can be merged down to maint-1.8.4 track and upwards.
Junio C Hamano (2):
parse-options: refactor human-friendly-integer parser out of pack-objects
repack: accept larger window-memory and max-pack-size
builtin/pack-objects.c | 25 ++++---------------------
builtin/repack.c | 12 ++++++------
parse-options.c | 17 +++++++++++++++++
parse-options.h | 5 +++++
4 files changed, 32 insertions(+), 27 deletions(-)
--
1.9-rc0-151-ga5225c0
next prev parent reply other threads:[~2014-01-22 19:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 22:48 git repack --max-pack-size broken in git-next Siddharth Agarwal
2014-01-21 23:01 ` Junio C Hamano
2014-01-21 23:26 ` Junio C Hamano
2014-01-22 19:58 ` Junio C Hamano [this message]
2014-01-22 19:58 ` [PATCH v2 1/2] parse-options: refactor human-friendly-integer parser out of pack-objects Junio C Hamano
2014-01-22 19:58 ` [PATCH v2 2/2] repack: accept larger window-memory and max-pack-size Junio C Hamano
2014-01-23 1:06 ` Jeff King
2014-01-23 1:26 ` Jeff King
2014-01-23 1:27 ` [PATCH 1/3] repack: fix typo in max-pack-size option Jeff King
2014-01-23 1:28 ` [PATCH 2/3] repack: make parsed string options const-correct Jeff King
2014-01-23 1:30 ` [PATCH 3/3] repack: propagate pack-objects options as strings Jeff King
2014-01-23 1:38 ` Jeff King
2014-01-23 18:37 ` [PATCH v2 2/2] repack: accept larger window-memory and max-pack-size Junio C Hamano
2014-01-22 22:33 ` [PATCH v2 0/2] Fix "repack --window-memory=4g" regression in 1.8.4 Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390420685-18449-1-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sid0@fb.com \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).