git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: jugg@hotmail.com, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 1/2] receive-pack: update $GIT_DIR/info before auto garbage collection
Date: Tue,  4 Feb 2014 13:52:44 +0700	[thread overview]
Message-ID: <1391496765-29564-1-git-send-email-pclouds@gmail.com> (raw)
In-Reply-To: <CACsJy8B0WKfxSYBSgRZQYz6_h+S9pGd03A=rrWM0_twRdKvyZw@mail.gmail.com>

Auto gc could take a long time, and it's optional. "git push" user
should be allowed to stop the program if they don't want to wait. Move
server update step before auto gc. So we're ready to die any time
since auto gc is kicked off.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/receive-pack.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 85bba35..82e2f76 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -1208,6 +1208,8 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix)
 			report(commands, unpack_status);
 		run_receive_hook(commands, "post-receive", 1);
 		run_update_post_hook(commands);
+		if (auto_update_server_info)
+			update_server_info(0);
 		if (auto_gc) {
 			const char *argv_gc_auto[] = {
 				"gc", "--auto", "--quiet", NULL,
@@ -1215,8 +1217,6 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix)
 			int opt = RUN_GIT_CMD | RUN_COMMAND_STDOUT_TO_STDERR;
 			run_command_v_opt(argv_gc_auto, opt);
 		}
-		if (auto_update_server_info)
-			update_server_info(0);
 		clear_shallow_info(&si);
 	}
 	if (use_sideband)
-- 
1.8.5.2.240.g8478abd

  reply	other threads:[~2014-02-04  6:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04  2:20 bug? git push triggers auto pack when gc.auto = 0 chris
2014-02-04  2:41 ` Duy Nguyen
2014-02-04  5:13   ` chris
2014-02-04  6:02     ` Duy Nguyen
2014-02-04  6:52       ` Nguyễn Thái Ngọc Duy [this message]
2014-02-04  6:52         ` [PATCH/RFC 2/2] receive-pack: hint that the user can stop "git push" at auto gc time Nguyễn Thái Ngọc Duy
2014-02-04 18:25           ` Junio C Hamano
2014-02-04 18:32             ` Junio C Hamano
2014-02-07 12:36               ` [PATCH/RFC 2/2] receive-pack: hint that the user can stop chris
2014-02-07 13:05                 ` Duy Nguyen
2014-02-07 16:47                   ` chris
2014-02-08  7:08               ` [PATCH v2 1/2] daemon: move daemonize() to libgit.a Nguyễn Thái Ngọc Duy
2014-02-08  7:08                 ` [PATCH v2 2/2] gc: config option for running --auto in background Nguyễn Thái Ngọc Duy
2014-02-10 11:03                   ` Erik Faye-Lund
2014-02-10 13:17                     ` Duy Nguyen
2014-02-10 13:33                       ` Erik Faye-Lund
2014-02-10 18:43                       ` Junio C Hamano
2014-02-10 19:11                         ` Junio C Hamano
2014-02-12  1:53                           ` Duy Nguyen
2014-02-12 17:36                             ` Junio C Hamano
2014-02-10 11:04                 ` [PATCH v2 1/2] daemon: move daemonize() to libgit.a Erik Faye-Lund
2014-02-10 18:46                 ` Junio C Hamano
2014-02-10 23:25                   ` Duy Nguyen
2014-02-11 18:08                     ` Junio C Hamano
2014-02-04  8:16       ` bug? git push triggers auto pack when gc.auto = 0 chris
2014-02-04  8:22     ` David Kastrup
2014-02-04  8:59       ` chris
2014-02-04  9:31         ` David Kastrup
2014-02-04 10:35           ` chris
2014-02-04 11:11             ` David Kastrup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391496765-29564-1-git-send-email-pclouds@gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jugg@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).