git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tay Ray Chuan <rctay89@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: Tay Ray Chuan <rctay89@gmail.com>
Subject: [PATCH 0/3] make commit --verbose work with --no-status
Date: Sat, 22 Feb 2014 03:09:19 +0800	[thread overview]
Message-ID: <1393009762-31133-1-git-send-email-rctay89@gmail.com> (raw)

One would expect 'git commit --verbose --no-status' to give a commit
message with a diff of the commit, sans the output of git-status.
However, this does not work currently; the commit message body is
entirely empty (diff is absent as well). This patch series attempts to
make this work, as one would expect.

[PATCH 1/3] rename STATUS_FORMAT_NONE to STATUS_FORMAT_DEFAULT

We first rename STATUS_FORMAT_NONE to *_DEFAULT, so that we can use it
to mean "no status output at all".

[PATCH 2/3] extract setting of wt_status.commitable flag out of
wt_status_print_updated()

Currently, the wt_status.commitable flag is set only when we call
wt_status_print(). * Extract this logic, so that we don't have to go
through the git-status output code.

* In fact, it is not set when --short or --porcelain are used. This
  series does not attempt to fix the bug, though it should be trivial to
  do so with this patch.

[PATCH 3/3] make commit --verbose work with --no-status

Actual work here.

-- 
1.9.0.291.g027825b

             reply	other threads:[~2014-02-21 19:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 19:09 Tay Ray Chuan [this message]
2014-02-21 19:09 ` [PATCH 1/3] rename STATUS_FORMAT_NONE to STATUS_FORMAT_DEFAULT Tay Ray Chuan
2014-02-21 19:09   ` [PATCH 2/3] extract setting of wt_status.commitable flag out of wt_status_print_updated() Tay Ray Chuan
2014-02-21 19:09     ` [PATCH 3/3] make commit --verbose work with --no-status Tay Ray Chuan
2014-02-22  8:31       ` Jeff King
2014-02-24  4:24         ` Tay Ray Chuan
2014-02-24  8:33           ` Jeff King
2014-02-22  8:24   ` [PATCH 1/3] rename STATUS_FORMAT_NONE to STATUS_FORMAT_DEFAULT Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393009762-31133-1-git-send-email-rctay89@gmail.com \
    --to=rctay89@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).