git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] OPTION_NUMBER should be replaced by OPTION_CMDMODE
@ 2014-02-28 15:24 Sun He
  0 siblings, 0 replies; only message in thread
From: Sun He @ 2014-02-28 15:24 UTC (permalink / raw)
  To: git; +Cc: mhagger, pclouds, Sun He

Signed-off-by: Sun He <sunheehnus@gmail.com>
---
 parse-options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/parse-options.c b/parse-options.c
index 7b8d3fa..59a52b0 100644
--- a/parse-options.c
+++ b/parse-options.c
@@ -371,7 +371,7 @@ static void parse_options_check(const struct option *opts)
 		case OPTION_NEGBIT:
 		case OPTION_SET_INT:
 		case OPTION_SET_PTR:
-		case OPTION_NUMBER:
+		case OPTION_CMDMODE:
 			if ((opts->flags & PARSE_OPT_OPTARG) ||
 			    !(opts->flags & PARSE_OPT_NOARG))
 				err |= optbug(opts, "should not accept an argument");
-- 
1.9.0.138.g2de3478.dirty
---
I came I came across this protential bug.
According to parse-options.h OPTION_CMDMODE is an option with noarguments and OPTION_NUMBER is special type option

Thanks,
He Sun

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-02-28 15:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-28 15:24 [PATCH] OPTION_NUMBER should be replaced by OPTION_CMDMODE Sun He

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).