* [PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning
@ 2014-02-28 16:26 Sun He
2014-02-28 20:05 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Sun He @ 2014-02-28 16:26 UTC (permalink / raw)
To: git; +Cc: mhagger, Sun He
Signed-off-by: Sun He <sunheehnus@gmail.com>
---
The tmpname is uninitialized and it should a bug
Please ignore the former patches about this with wrong format.
I am sorry to cause a jam in your inbox. ^_^
In the end, I wanna thank Michael Haggerty who give me help.
builtin/pack-objects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..4922ce5 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -823,7 +823,7 @@ static void write_pack_file(void)
utb.modtime = --last_mtime;
if (utime(pack_tmp_name, &utb) < 0)
warning("failed utime() on %s: %s",
- tmpname, strerror(errno));
+ pack_tmp_name, strerror(errno));
}
/* Enough space for "-<sha-1>.pack"? */
--
1.9.0.138.g2de3478.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning
2014-02-28 16:26 [PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning Sun He
@ 2014-02-28 20:05 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2014-02-28 20:05 UTC (permalink / raw)
To: Sun He; +Cc: git, mhagger
Sun He <sunheehnus@gmail.com> writes:
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
> The tmpname is uninitialized and it should a bug
>
> Please ignore the former patches about this with wrong format.
> I am sorry to cause a jam in your inbox. ^_^
>
> In the end, I wanna thank Michael Haggerty who give me help.
If you look at "git log" output, you would notice that people write
something like
Helped-by: Michael Haggerty <mhagger@alum.mit.edu>
before your S-o-b: line for a case like this.
We can see that you are replacing tmpname with pack_tmp_name in
warning without you writing on the subject line. The commit log is
where you explain *why* that change is the right thing to do. And
that is totally lacking in this message.
> builtin/pack-objects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
> utb.modtime = --last_mtime;
> if (utime(pack_tmp_name, &utb) < 0)
> warning("failed utime() on %s: %s",
> - tmpname, strerror(errno));
> + pack_tmp_name, strerror(errno));
> }
>
> /* Enough space for "-<sha-1>.pack"? */
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning
@ 2014-02-28 15:37 Sun He
0 siblings, 0 replies; 3+ messages in thread
From: Sun He @ 2014-02-28 15:37 UTC (permalink / raw)
To: git; +Cc: mhagger, sunshine, Sun He
Signed-off-by: Sun He <sunheehnus@gmail.com>
---
builtin/pack-objects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..4922ce5 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -823,7 +823,7 @@ static void write_pack_file(void)
utb.modtime = --last_mtime;
if (utime(pack_tmp_name, &utb) < 0)
warning("failed utime() on %s: %s",
- tmpname, strerror(errno));
+ pack_tmp_name, strerror(errno));
}
/* Enough space for "-<sha-1>.pack"? */
--
1.9.0.138.g2de3478.dirty
---
The tmpname is uninitialized and it should a bug
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-28 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-28 16:26 [PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning Sun He
2014-02-28 20:05 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2014-02-28 15:37 Sun He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).