From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
"Christian Couder" <christian.couder@gmail.com>,
"Nicolas Pitre" <nico@fluxnic.net>,
"Jakub Narębski" <jnareb@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH v2 0/2] More object-related docstrings
Date: Fri, 28 Feb 2014 17:29:15 +0100 [thread overview]
Message-ID: <1393604957-7571-1-git-send-email-mhagger@alum.mit.edu> (raw)
This patch series applies on top of mh/replace-refs-variable-rename,
simply because one of the comments refers to the global variable
check_replace_refs by its new name.
This is a re-roll of patches 1/6 and 6/6 of the series
"mh/object-code-cleanup" that I submitted earlier [1]. Patches 2-5 of
that series have already been queued.
The first patch emphasizes that do_lookup_replace_object() is only
meant for internal use, and moves the real docstring for that function
from the header file to the implementation file.
The second patch changes the docstring for hash_obj() to mention that
its return value is not consistent across architectures, and adds a
comment within the function explaining some points about the
implementation that were suggested in the discussion about v1.
Thanks to Junio, Christian, Nicolas, Jakub, and Jonathan for their
comments on v1.
Michael
[1] http://thread.gmane.org/gmane.comp.version-control.git/242469
Michael Haggerty (2):
Add docstrings for lookup_replace_object() and
do_lookup_replace_object()
Document some functions defined in object.c
cache.h | 13 +++++++++++++
object.c | 29 ++++++++++++++++++++++++++++-
object.h | 7 +++++++
replace_object.c | 7 +++++++
4 files changed, 55 insertions(+), 1 deletion(-)
--
1.8.5.3
next reply other threads:[~2014-02-28 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 16:29 Michael Haggerty [this message]
2014-02-28 16:29 ` [PATCH v2 1/2] Add docstrings for lookup_replace_object() and do_lookup_replace_object() Michael Haggerty
2014-02-28 21:17 ` Junio C Hamano
2014-02-28 16:29 ` [PATCH v2 2/2] Document some functions defined in object.c Michael Haggerty
2014-02-28 17:49 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393604957-7571-1-git-send-email-mhagger@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).