From: Sun He <sunheehnus@gmail.com>
To: git@vger.kernel.org
Cc: sunshine@sunshineco.com, Sun He <sunheehnus@gmail.com>
Subject: [PATCH v3] write_pack_file: use correct variable in diagnostic
Date: Sun, 2 Mar 2014 15:30:11 +0800 [thread overview]
Message-ID: <1393745411-30980-1-git-send-email-sunheehnus@gmail.com> (raw)
'pack_tmp_name' is the subject of the utime() check, so report it in the
warning, not the uninitialized 'tmpname'
Signed-off-by: Sun He <sunheehnus@gmail.com>
---
Changing the subject and adding valid information as tutored by
Eric Sunshine.
Thanks to him.
builtin/pack-objects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..4922ce5 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -823,7 +823,7 @@ static void write_pack_file(void)
utb.modtime = --last_mtime;
if (utime(pack_tmp_name, &utb) < 0)
warning("failed utime() on %s: %s",
- tmpname, strerror(errno));
+ pack_tmp_name, strerror(errno));
}
/* Enough space for "-<sha-1>.pack"? */
--
1.9.0.138.g2de3478.dirty
next reply other threads:[~2014-03-02 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 7:30 Sun He [this message]
2014-03-02 18:42 ` [PATCH v3] write_pack_file: use correct variable in diagnostic Eric Sunshine
2014-03-03 1:20 ` He Sun
2014-03-03 18:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393745411-30980-1-git-send-email-sunheehnus@gmail.com \
--to=sunheehnus@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).