* [PATCH v3] write_pack_file: use correct variable in diagnostic
@ 2014-03-02 7:30 Sun He
2014-03-02 18:42 ` Eric Sunshine
2014-03-03 18:43 ` Junio C Hamano
0 siblings, 2 replies; 4+ messages in thread
From: Sun He @ 2014-03-02 7:30 UTC (permalink / raw)
To: git; +Cc: sunshine, Sun He
'pack_tmp_name' is the subject of the utime() check, so report it in the
warning, not the uninitialized 'tmpname'
Signed-off-by: Sun He <sunheehnus@gmail.com>
---
Changing the subject and adding valid information as tutored by
Eric Sunshine.
Thanks to him.
builtin/pack-objects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..4922ce5 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -823,7 +823,7 @@ static void write_pack_file(void)
utb.modtime = --last_mtime;
if (utime(pack_tmp_name, &utb) < 0)
warning("failed utime() on %s: %s",
- tmpname, strerror(errno));
+ pack_tmp_name, strerror(errno));
}
/* Enough space for "-<sha-1>.pack"? */
--
1.9.0.138.g2de3478.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] write_pack_file: use correct variable in diagnostic
2014-03-02 7:30 [PATCH v3] write_pack_file: use correct variable in diagnostic Sun He
@ 2014-03-02 18:42 ` Eric Sunshine
2014-03-03 1:20 ` He Sun
2014-03-03 18:43 ` Junio C Hamano
1 sibling, 1 reply; 4+ messages in thread
From: Eric Sunshine @ 2014-03-02 18:42 UTC (permalink / raw)
To: Sun He, Junio C Hamano; +Cc: Git List
On Sun, Mar 2, 2014 at 2:30 AM, Sun He <sunheehnus@gmail.com> wrote:
> 'pack_tmp_name' is the subject of the utime() check, so report it in the
> warning, not the uninitialized 'tmpname'
>
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>
> Changing the subject and adding valid information as tutored by
> Eric Sunshine.
> Thanks to him.
>
> builtin/pack-objects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
> utb.modtime = --last_mtime;
> if (utime(pack_tmp_name, &utb) < 0)
> warning("failed utime() on %s: %s",
> - tmpname, strerror(errno));
> + pack_tmp_name, strerror(errno));
> }
>
> /* Enough space for "-<sha-1>.pack"? */
> --
> 1.9.0.138.g2de3478.dirty
Nicely done. Everything is where it ought to be.
As this is an actual bug fix (not just a GSoC microproject):
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] write_pack_file: use correct variable in diagnostic
2014-03-02 18:42 ` Eric Sunshine
@ 2014-03-03 1:20 ` He Sun
0 siblings, 0 replies; 4+ messages in thread
From: He Sun @ 2014-03-03 1:20 UTC (permalink / raw)
To: Eric Sunshine, git
2014-03-03 2:42 GMT+08:00 Eric Sunshine <sunshine@sunshineco.com>:
> On Sun, Mar 2, 2014 at 2:30 AM, Sun He <sunheehnus@gmail.com> wrote:
>> 'pack_tmp_name' is the subject of the utime() check, so report it in the
>> warning, not the uninitialized 'tmpname'
>>
>> Signed-off-by: Sun He <sunheehnus@gmail.com>
>> ---
>>
>> Changing the subject and adding valid information as tutored by
>> Eric Sunshine.
>> Thanks to him.
>>
>> builtin/pack-objects.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
>> index c733379..4922ce5 100644
>> --- a/builtin/pack-objects.c
>> +++ b/builtin/pack-objects.c
>> @@ -823,7 +823,7 @@ static void write_pack_file(void)
>> utb.modtime = --last_mtime;
>> if (utime(pack_tmp_name, &utb) < 0)
>> warning("failed utime() on %s: %s",
>> - tmpname, strerror(errno));
>> + pack_tmp_name, strerror(errno));
>> }
>>
>> /* Enough space for "-<sha-1>.pack"? */
>> --
>> 1.9.0.138.g2de3478.dirty
>
> Nicely done. Everything is where it ought to be.
>
> As this is an actual bug fix (not just a GSoC microproject):
>
> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Thank you so much for everything you have done.
I am honored to do this with all your support and kindness.
Regards，
He Sun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] write_pack_file: use correct variable in diagnostic
2014-03-02 7:30 [PATCH v3] write_pack_file: use correct variable in diagnostic Sun He
2014-03-02 18:42 ` Eric Sunshine
@ 2014-03-03 18:43 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2014-03-03 18:43 UTC (permalink / raw)
To: Sun He; +Cc: git, sunshine
Sun He <sunheehnus@gmail.com> writes:
> 'pack_tmp_name' is the subject of the utime() check, so report it in the
> warning, not the uninitialized 'tmpname'
>
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>
> Changing the subject and adding valid information as tutored by
> Eric Sunshine.
> Thanks to him.
>
> builtin/pack-objects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
> utb.modtime = --last_mtime;
> if (utime(pack_tmp_name, &utb) < 0)
> warning("failed utime() on %s: %s",
> - tmpname, strerror(errno));
> + pack_tmp_name, strerror(errno));
> }
>
> /* Enough space for "-<sha-1>.pack"? */
Very nicely done. Thanks.
And big Thanks to Eric guiding this patch through.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-03 18:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-02 7:30 [PATCH v3] write_pack_file: use correct variable in diagnostic Sun He
2014-03-02 18:42 ` Eric Sunshine
2014-03-03 1:20 ` He Sun
2014-03-03 18:43 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).