From: Sun He <sunheehnus@gmail.com>
To: git@vger.kernel.org
Cc: sunshine@sunshineco.com, Sun He <sunheehnus@gmail.com>
Subject: [PATCH v3] Place cache.h at the first place to match general rule
Date: Sun, 2 Mar 2014 16:31:41 +0800 [thread overview]
Message-ID: <1393749101-14985-1-git-send-email-sunheehnus@gmail.com> (raw)
The general rule is if cache.h or git-compat-util.h is included,
it is the first #include.
As builtin.h starts with git-compat-util.h, files that start with builtin.h
are not changed.
Helped-by: Duy Nguyen <pclouds@gmail.com>
Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Sun He <sunheehnus@gmail.com>
---
"PATCH v3" fix the position of information I want to convey to readers,
with the directions of Eric Sunshine.
sigchain.c and test-sigchain.c are started with "sigchain.h"
I checked sigchain.h, and it didn't import any bug.
But to keep consistant with general rule, we should take this patch.
sigchain.c | 2 +-
test-sigchain.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sigchain.c b/sigchain.c
index 1118b99..faa375d 100644
--- a/sigchain.c
+++ b/sigchain.c
@@ -1,5 +1,5 @@
-#include "sigchain.h"
#include "cache.h"
+#include "sigchain.h"
#define SIGCHAIN_MAX_SIGNALS 32
diff --git a/test-sigchain.c b/test-sigchain.c
index 42db234..e499fce 100644
--- a/test-sigchain.c
+++ b/test-sigchain.c
@@ -1,5 +1,5 @@
-#include "sigchain.h"
#include "cache.h"
+#include "sigchain.h"
#define X(f) \
static void f(int sig) { \
--
1.9.0.138.g2de3478.dirty
next reply other threads:[~2014-03-02 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 8:31 Sun He [this message]
2014-03-03 7:44 ` [PATCH v3] Place cache.h at the first place to match general rule Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393749101-14985-1-git-send-email-sunheehnus@gmail.com \
--to=sunheehnus@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).