From: Guanglin Xu <mzguanglin@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH v2] branch.c: change install_branch_config() to use skip_prefix()
Date: Sun, 2 Mar 2014 23:55:55 +0800 [thread overview]
Message-ID: <1393775755-15359-1-git-send-email-mzguanglin@gmail.com> (raw)
Change install_branch_config() to use skip_prefix() and make it conform to the usage of previous starts_with(). This is because the proper usage of skip_prefix() overrides the functionality of starts_with(). Thorough replacements may finally remove the starts_with() function and reduce code redundency.
Signed-off-by: Guanglin Xu <mzguanglin@gmail.com>
---
branch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/branch.c b/branch.c
index 723a36b..ca4e824 100644
--- a/branch.c
+++ b/branch.c
@@ -50,7 +50,7 @@ static int should_setup_rebase(const char *origin)
void install_branch_config(int flag, const char *local, const char *origin, const char *remote)
{
const char *shortname = remote + 11;
- int remote_is_branch = starts_with(remote, "refs/heads/");
+ int remote_is_branch = (NULL != skip_prefix(remote ,"refs/heads/"));
struct strbuf key = STRBUF_INIT;
int rebasing = should_setup_rebase(origin);
--
1.9.0
Hi,
I am Guanglin Xu. I plan to apply for GSoC 2014.
This patch is in accordance with the idea#2 of GSoC2014 Microproject. Any comments are welcomed.
next reply other threads:[~2014-03-02 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 15:55 Guanglin Xu [this message]
2014-03-02 22:56 ` [PATCH v2] branch.c: change install_branch_config() to use skip_prefix() Eric Sunshine
2014-03-03 1:41 ` Guanglin Xu
2014-03-03 18:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393775755-15359-1-git-send-email-mzguanglin@gmail.com \
--to=mzguanglin@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).