From: Siddharth Goel <siddharth98391@gmail.com>
To: git@vger.kernel.org
Cc: sunshine@sunshineco.com, Siddharth Goel <siddharth98391@gmail.com>
Subject: [PATCH v3] skip_prefix: rewrite so that prefix is scanned once
Date: Mon, 3 Mar 2014 11:13:04 +0800 [thread overview]
Message-ID: <1393816384-3300-1-git-send-email-siddharth98391@gmail.com> (raw)
Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Siddharth Goel <siddharth98391@gmail.com>
---
Added a space after colon in the subject as compared to previous
patch [PATCH v2].
[PATCH v2]: http://thread.gmane.org/gmane.comp.version-control.git/243150
git-compat-util.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 614a5e9..550dce3 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -357,8 +357,11 @@ extern int suffixcmp(const char *str, const char *suffix);
static inline const char *skip_prefix(const char *str, const char *prefix)
{
- size_t len = strlen(prefix);
- return strncmp(str, prefix, len) ? NULL : str + len;
+ while (*prefix != '\0' && *str == *prefix) {
+ str++;
+ prefix++;
+ }
+ return (*prefix == '\0' ? str : NULL);
}
#if defined(NO_MMAP) || defined(USE_WIN32_MMAP)
--
1.9.0.138.g2de3478.dirty
next reply other threads:[~2014-03-03 3:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 3:13 Siddharth Goel [this message]
2014-03-03 19:05 ` [PATCH v3] skip_prefix: rewrite so that prefix is scanned once Junio C Hamano
2014-03-03 22:43 ` Junio C Hamano
2014-03-03 23:22 ` David Kastrup
2014-03-03 23:35 ` Junio C Hamano
2014-03-03 23:37 ` Duy Nguyen
2014-03-04 0:09 ` David Kastrup
2014-03-04 1:58 ` Duy Nguyen
2014-03-04 9:18 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393816384-3300-1-git-send-email-siddharth98391@gmail.com \
--to=siddharth98391@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).