git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Quint Guvernator <quintus.public@gmail.com>
To: git@vger.kernel.org
Cc: Quint Guvernator <quintus.public@gmail.com>
Subject: [PATCH v3 0/1] general style: replaces memcmp() with starts_with()
Date: Sat, 15 Mar 2014 12:39:12 -0400	[thread overview]
Message-ID: <1394901553-69548-1-git-send-email-quintus.public@gmail.com> (raw)

Hi, folks.

I've looked through the list's responses and removed the most objectionable
hunks from the patch v2, especially in cases where starts_with either hurts
readability or further obscures the use of magic numbers. Let me know what you
all think about the changes.

Thank you all again for your help. This is my first patch here, and has been
quite a microproject indeed!

Quint Guvernator (1):
  general style: replaces memcmp() with starts_with()

 builtin/apply.c                           |  6 +++---
 builtin/for-each-ref.c                    |  2 +-
 builtin/get-tar-commit-id.c               |  2 +-
 builtin/mktag.c                           |  8 ++++----
 builtin/patch-id.c                        | 18 +++++++++---------
 commit.c                                  |  4 ++--
 connect.c                                 |  6 +++---
 contrib/convert-objects/convert-objects.c |  6 +++---
 convert.c                                 |  2 +-
 http-walker.c                             |  2 +-
 imap-send.c                               |  6 +++---
 pack-write.c                              |  2 +-
 remote.c                                  |  2 +-
 13 files changed, 33 insertions(+), 33 deletions(-)

-- 
1.9.0

             reply	other threads:[~2014-03-15 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-15 16:39 Quint Guvernator [this message]
2014-03-15 16:39 ` [PATCH v3 1/1] general style: replaces memcmp() with starts_with() Quint Guvernator
2014-03-17 16:29   ` Michael Haggerty
2014-03-17 20:36     ` Quint Guvernator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394901553-69548-1-git-send-email-quintus.public@gmail.com \
    --to=quintus.public@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).