From: Steven Penny <svnpenn@gmail.com>
To: git@vger.kernel.org
Cc: Steven Penny <svnpenn@gmail.com>
Subject: [PATCH] gitk: Avoid issues with script path format
Date: Sun, 16 Mar 2014 01:12:22 -0500 [thread overview]
Message-ID: <1394950342-1580-1-git-send-email-svnpenn@gmail.com> (raw)
Tk’s "wish" for Windows can be built two ways
win this provides a "wish" that uses GDI; it only understands Windows
paths such as C:\foo\bar
unix this provides a "wish" that uses X11; it understands Windows and Cygwin
paths such as C:\foo\bar or /foo/bar
Some Cygwin users will prefer to use the "win" version, as it avoids the large
X11 dependency. However Cygwin passes the path "/bin/gitk" or similar and the
"win" version of "wish" will not understand this. However "wish" does understand
STDIN. Options such as "--all" will still work using this method as well.
Signed-off-by: Steven Penny <svnpenn@gmail.com>
---
gitk-git/gitk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 90764e8..64a125d 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -1,6 +1,6 @@
#!/bin/sh
# Tcl ignores the next line -*- tcl -*- \
-exec wish "$0" -- "$@"
+exec wish < "$0" -- "$@"
# Copyright © 2005-2014 Paul Mackerras. All rights reserved.
# This program is free software; it may be used, copied, modified
--
1.8.5.2
reply other threads:[~2014-03-16 6:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394950342-1580-1-git-send-email-svnpenn@gmail.com \
--to=svnpenn@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).