git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: babourn <ba.bourn@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 2/2][GSoC 2014] diff: used is_dot_or_dotdot() in code
Date: Tue, 18 Mar 2014 18:30:36 -0700 (PDT)	[thread overview]
Message-ID: <1395192636735-7605956.post@n2.nabble.com> (raw)
In-Reply-To: <CAM+=D-Ac2yL02-6qGQFuV_qz4FKt_6EGwRHk4+MLDnSb5CgucQ@mail.gmail.com>

in accordance with the GSoC Microproject implemented
the call is_dot_or_dotdot() in the code in order to
further universalize the call to the function and
increase code continuity.

Signed-off-by: Brian Bourn <bab2177@columbia.edu>
---
 diff-no-index.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/diff-no-index.c b/diff-no-index.c
index ba915af..44cce25 100644
--- a/diff-no-index.c
+++ b/diff-no-index.c
@@ -26,7 +26,7 @@ static int read_directory_contents(const char *path,
struct string_list *list)
  return error("Could not open directory %s", path);

  while ((e = readdir(dir)))
- if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
+ if (!is_dot_or_dotdot(e->d_name))
  string_list_insert(list, e->d_name);

  closedir(dir);
--
1.9.0



--
View this message in context: http://git.661346.n2.nabble.com/PATCH-GSoC-2014-diff-Imported-dir-h-and-renamed-read-directory-tp7605950p7605956.html
Sent from the git mailing list archive at Nabble.com.

  parent reply	other threads:[~2014-03-19  1:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19  0:35 [PATCH] [GSoC 2014]diff: Imported dir.h and renamed read_directory() Brian Bourn
2014-03-19  1:19 ` Eric Sunshine
2014-03-19  1:30 ` babourn [this message]
2014-03-19  3:45   ` [PATCH 2/2][GSoC 2014] diff: used is_dot_or_dotdot() in code Eric Sunshine
     [not found]     ` <CAM+=D-CO9A4hYb+9tVf_cAOMqkTm3taBLPp0eHtFkuMUCFw2ng@mail.gmail.com>
2014-03-19  4:08       ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395192636735-7605956.post@n2.nabble.com \
    --to=ba.bourn@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).