From: Hiroyuki Sano <sh19910711@gmail.com>
To: git@vger.kernel.org
Cc: Hiroyuki Sano <sh19910711@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: [PATCH v2 2/3][GSOC] diff: use is_dot_or_dotdot() instead of strcmp()
Date: Wed, 19 Mar 2014 20:23:49 +0900 [thread overview]
Message-ID: <1395228230-10189-2-git-send-email-sh19910711@gmail.com> (raw)
In-Reply-To: <1395228230-10189-1-git-send-email-sh19910711@gmail.com>
The is_dot_or_dotdot() is used to check if the string is either "." or "..".
Include the "dir.h" header file to use is_dot_or_dotdot().
Signed-off-by: Hiroyuki Sano <sh19910711@gmail.com>
---
diff-no-index.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/diff-no-index.c b/diff-no-index.c
index 20b6a8a..8e642b3 100644
--- a/diff-no-index.c
+++ b/diff-no-index.c
@@ -11,6 +11,7 @@
#include "tag.h"
#include "diff.h"
#include "diffcore.h"
+#include "dir.h"
#include "revision.h"
#include "log-tree.h"
#include "builtin.h"
@@ -25,7 +26,7 @@ static int get_path_list(const char *path, struct string_list *list)
return error("Could not open directory %s", path);
while ((e = readdir(dir)))
- if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
+ if (!is_dot_or_dotdot(e->d_name))
string_list_insert(list, e->d_name);
closedir(dir);
--
1.9.0
next prev parent reply other threads:[~2014-03-19 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 11:23 [PATCH v2 1/3][GSOC] diff: rename read_directory() to get_path_list() Hiroyuki Sano
2014-03-19 11:23 ` Hiroyuki Sano [this message]
2014-03-19 21:15 ` [PATCH v2 2/3][GSOC] diff: use is_dot_or_dotdot() instead of strcmp() Eric Sunshine
2014-03-19 11:23 ` [PATCH v2 3/3][GSOC] fsck: replace if-statements to logical expressions Hiroyuki Sano
2014-03-19 18:29 ` Junio C Hamano
2014-03-19 21:15 ` [PATCH v2 1/3][GSOC] diff: rename read_directory() to get_path_list() Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395228230-10189-2-git-send-email-sh19910711@gmail.com \
--to=sh19910711@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).