From: Andrei Dinu <mandrei.dinu@gmail.com>
To: git@vger.kernel.org
Cc: Andrei Dinu <mandrei.dinu@gmail.com>
Subject: [PATCH v4 2/2] diff-no-index.c: read_directory_path() use is_dot_or_dotdot().
Date: Wed, 19 Mar 2014 17:46:30 +0200 [thread overview]
Message-ID: <1395243990-6030-1-git-send-email-mandrei.dinu@gmail.com> (raw)
Implement code so read_directory_path() use is_dot_or_dotdot() from "dir.h"
instead of strcmp().
Signed-off-by: Andrei Dinu <mandrei.dinu@gmail.com>
---
I plan on applying to GSoc 2014.
diff-no-index.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/diff-no-index.c b/diff-no-index.c
index 5e4a76c..2d1165f 100644
--- a/diff-no-index.c
+++ b/diff-no-index.c
@@ -15,6 +15,7 @@
#include "log-tree.h"
#include "builtin.h"
#include "string-list.h"
+#include "dir.h"
static int read_directory_path(const char *path, struct string_list *list)
{
@@ -25,7 +26,7 @@ static int read_directory_path(const char *path, struct string_list *list)
return error("Could not open directory %s", path);
while ((e = readdir(dir)))
- if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
+ if (!is_dot_or_dotdot(e->d_name))
string_list_insert(list, e->d_name);
closedir(dir);
--
1.7.9.5
reply other threads:[~2014-03-19 15:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395243990-6030-1-git-send-email-mandrei.dinu@gmail.com \
--to=mandrei.dinu@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).