git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Bourn <ba.bourn@gmail.com>
To: git@vger.kernel.org
Cc: Brian Bourn <ba.bourn@gmail.com>
Subject: [PATCH v3 2/2][GSoC] diff-no-index: replace manual "."/".." check with is_dot_or_dotdot()
Date: Wed, 19 Mar 2014 11:58:22 -0400	[thread overview]
Message-ID: <1395244702-659-2-git-send-email-ba.bourn@gmail.com> (raw)
In-Reply-To: <1395244702-659-1-git-send-email-ba.bourn@gmail.com>

Signed-off-by: Brian Bourn <ba.bourn@gmail.com>
---
Part 2 of my submission for GSoC
 diff-no-index.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/diff-no-index.c b/diff-no-index.c
index ec51106..c554691 100644
--- a/diff-no-index.c
+++ b/diff-no-index.c
@@ -15,6 +15,7 @@
 #include "log-tree.h"
 #include "builtin.h"
 #include "string-list.h"
+#include "dir.h"
 
 static int read_directory_contents(const char *path, struct string_list *list)
 {
@@ -25,7 +26,7 @@ static int read_directory_contents(const char *path, struct string_list *list)
 		return error("Could not open directory %s", path);
 
 	while ((e = readdir(dir)))
-		if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
+		if (!is_dot_or_dotdot(e->d_name))
 			string_list_insert(list, e->d_name);
 
 	closedir(dir);
-- 
1.9.0

  reply	other threads:[~2014-03-19 15:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 15:58 [PATCH v3 1/2][GSoC] diff-no-index: rename read_directory() Brian Bourn
2014-03-19 15:58 ` Brian Bourn [this message]
2014-03-19 18:31 ` Junio C Hamano
2014-03-19 19:15   ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395244702-659-2-git-send-email-ba.bourn@gmail.com \
    --to=ba.bourn@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).