From: MustafaOrkunAcar <mustafaorkunacar@gmail.com>
To: git@vger.kernel.org
Cc: MustafaOrkunAcar <mustafaorkunacar@gmail.com>
Subject: [PATCH] Rewritten fetch-pack.c:filter_refs() using starts_with() instead of memcmp()
Date: Thu, 20 Mar 2014 12:04:49 +0200 [thread overview]
Message-ID: <1395309889-340-1-git-send-email-mustafaorkunacar@gmail.com> (raw)
Hi, I have completed one of the microprojects -14th one: "Change fetch-pack.c:filter_refs() to use starts_with() instead of memcmp()." The only line in the function filter_refs() containing memcmp() is changed with starts_with(). I plan to apply for GSoC 2014. Any feedback is appreciated. Thanks.
Signed-off-by: MustafaOrkunAcar <mustafaorkunacar@gmail.com>
---
fetch-pack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fetch-pack.c b/fetch-pack.c
index f061f1f..17823ab 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -506,7 +506,7 @@ static void filter_refs(struct fetch_pack_args *args,
int keep = 0;
next = ref->next;
- if (!memcmp(ref->name, "refs/", 5) &&
+ if (starts_with(ref->name, "refs/") &&
check_refname_format(ref->name, 0))
; /* trash */
else {
--
1.9.1.286.g5172cb3
next reply other threads:[~2014-03-20 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 10:04 MustafaOrkunAcar [this message]
2014-03-21 6:27 ` [PATCH] Rewritten fetch-pack.c:filter_refs() using starts_with() instead of memcmp() Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395309889-340-1-git-send-email-mustafaorkunacar@gmail.com \
--to=mustafaorkunacar@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).