From: Ashwin Jha <ajha.dev@gmail.com>
To: git@vger.kernel.org
Cc: Ashwin Jha <ajha.dev@gmail.com>
Subject: [PATCH v3 1/2] fsck.c: modify fsck_ident() and fsck_commit()
Date: Mon, 24 Mar 2014 17:38:21 +0530 [thread overview]
Message-ID: <1395662901-10617-1-git-send-email-ajha.dev@gmail.com> (raw)
In fsck_ident(): Replace argument char **ident with const char **ident
In fsck_commit(): Replace char *buffer with const char *buffer
In both the cases, referenced memory addresses are not modified. So, it
will be a good practice, to declare them as const.
Signed-off-by: Ashwin Jha <ajha.dev@gmail.com>
---
Change in fsck_commit() and fsck_ident() as per the discussion with
Eric (follow at [1]).
[1]: http://git.661346.n2.nabble.com/PATCH-Modify-fsck-commit-Replace-memcmp-by-skip-prefix-td7606321.html
fsck.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fsck.c b/fsck.c
index 64bf279..b5f017f 100644
--- a/fsck.c
+++ b/fsck.c
@@ -243,7 +243,7 @@ static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
return retval;
}
-static int fsck_ident(char **ident, struct object *obj, fsck_error error_func)
+static int fsck_ident(const char **ident, struct object *obj, fsck_error error_func)
{
char *end;
@@ -284,7 +284,7 @@ static int fsck_ident(char **ident, struct object *obj, fsck_error error_func)
static int fsck_commit(struct commit *commit, fsck_error error_func)
{
- char *buffer = commit->buffer;
+ const char *buffer = commit->buffer;
unsigned char tree_sha1[20], sha1[20];
struct commit_graft *graft;
int parents = 0;
--
1.9.1
next reply other threads:[~2014-03-24 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 12:08 Ashwin Jha [this message]
2014-03-25 6:50 ` [PATCH v3 1/2] fsck.c: modify fsck_ident() and fsck_commit() Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395662901-10617-1-git-send-email-ajha.dev@gmail.com \
--to=ajha.dev@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).