From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 015/142] t0300-credentials.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:22:36 -0700 Message-ID: <1395768283-31135-16-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:38 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVEB-0004n1-7E for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:31 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755336AbaCYRZO convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:25:14 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:43935 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754049AbaCYRZH (ORCPT ); Tue, 25 Mar 2014 13:25:07 -0400 Received: by mail-pa0-f42.google.com with SMTP id fb1so741625pad.15 for ; Tue, 25 Mar 2014 10:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ZmS6Ol+xBatFqoM6Z3AymO+itCM5OAI/V7zKAoXloGY=; b=wjd9+Y8XbAROp0Jdfg9HAcLxgDgB1sxV77RDxhC95UHuPyLFg1D7086R8ksk2hFUN2 MfS/DWAHLwe8nYpDI+0kEIXQIVNQZ0+37vSYsJzZnp3dU6MsnTgWYZb+7XYL5QtPtW4u XdtOwcnWzwJIhC7rK5IODwLLDIHxBj1rYB5epupSD/5nY3kspwV0bPNmA6zXLw3MpD0s 3qbNYvTok1JB+xvX/lL4GYWD3104sPponyBmvhGNMO0CxLJIKLJiZV86ktlXZq3f5JII X7HxYeUjv/LIdeGoBtJQdBpzILc6RT7bNKV+C5hNScCS3DOEWGnOujWdM8O39kVXSk0T nHAA== X-Received: by 10.66.146.170 with SMTP id td10mr80960506pab.105.1395768307415; Tue, 25 Mar 2014 10:25:07 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.06 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:25:06 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t0300-credentials.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh index 538ea5f..57ea5a1 100755 --- a/t/t0300-credentials.sh +++ b/t/t0300-credentials.sh @@ -6,7 +6,7 @@ test_description=3D'basic credential helper tests' =20 test_expect_success 'setup helper scripts' ' cat >dump <<-\EOF && - whoami=3D`echo $0 | sed s/.*git-credential-//` + whoami=3D$(echo $0 | sed s/.*git-credential-//) echo >&2 "$whoami: $*" OIFS=3D$IFS IFS=3D=3D --=20 1.7.10.4