From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 019/142] t1003-read-tree-prefix.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:22:40 -0700 Message-ID: <1395768283-31135-20-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:25:29 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSV6L-0005m3-4F for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:25:25 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755341AbaCYRZQ convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:25:16 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:58069 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754665AbaCYRZM (ORCPT ); Tue, 25 Mar 2014 13:25:12 -0400 Received: by mail-pd0-f176.google.com with SMTP id r10so717858pdi.7 for ; Tue, 25 Mar 2014 10:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=z11jor+kLd6eVlaVFA7oEDqmJvtgGdGVZLcu1Qbglt8=; b=KySPiKKrtMQqF1sNOoiXHhUWAQL54I53mnDrZ6WN2HmylFf1FtMTt6DM3fkbbt3E3R U4CFf1ISBP9RWDxJHXNqwggaOYmM5djYk3FJCMVvYAmzIeorP+LIL+lr+OJxU1IdrCk0 Ypd6EBVdJyrxS1Y1Ajmt9rOkmMTjPBFZxl+dv1CGZrOoI5byGfQCDazBUOPDiK/vGY5J RE0ZzLNMJ+WoJCrYvmpxt19SbIRgvSXJrshutsrrF84ky80uJ/dRgGiJTn2iOq1HObnS 2b1VwefN/P329E5Pd7pil0MHr6tmix3GzC3ewGlrW5VOc8K5PZxUkA817aPGrTCXdaUS 5vWw== X-Received: by 10.68.129.5 with SMTP id ns5mr12401366pbb.147.1395768312255; Tue, 25 Mar 2014 10:25:12 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.11 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:25:11 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t1003-read-tree-prefix.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t1003-read-tree-prefix.sh b/t/t1003-read-tree-prefix.sh index 8c6d67e..b6111cd 100755 --- a/t/t1003-read-tree-prefix.sh +++ b/t/t1003-read-tree-prefix.sh @@ -11,7 +11,7 @@ test_description=3D'git read-tree --prefix test. test_expect_success setup ' echo hello >one && git update-index --add one && - tree=3D`git write-tree` && + tree=3D$(git write-tree) && echo tree is $tree ' =20 --=20 1.7.10.4