From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 022/142] t1050-large.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:22:43 -0700 Message-ID: <1395768283-31135-23-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:32 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVEA-0004n1-5R for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:30 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755348AbaCYRZS convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:25:18 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:45980 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755339AbaCYRZQ (ORCPT ); Tue, 25 Mar 2014 13:25:16 -0400 Received: by mail-pd0-f177.google.com with SMTP id y10so717634pdj.22 for ; Tue, 25 Mar 2014 10:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=tu5mxQiYUiIhvDIPyhrPVYCbHHR3MyWYE73RblOFB18=; b=tl2xJ4yFgnWfspwRpmaCNf4wZsLfcavQbwmKRyjQHToTBNYDLidEzE/UKW+KC5zw7W 2ATWJzOhamFYsjNFsCQht79dbHSypCr/1CiYtzPiUI9FE0P2T9kRhk8dN3XNHs39r9OF 9+A2ESDb0FNE0dT0D9wz44Uk4++2CgwyZ6zJkcWdhUKO/QYqmRf8juMXEFSSW7ftc7Yp MFq3yBmpf0Uf5WouCvmYj1QX2v/97TEVMwAe7vNFZnoOePIoqDO6oDwORPN/u4coIEgC fn9jsQQgXGIee4UZdtOHg4kK+xm57gO90Ae2qVVvhvRsD85b6Z4/d4ktmn063LgQPmo8 jo1w== X-Received: by 10.68.76.68 with SMTP id i4mr80829136pbw.73.1395768315661; Tue, 25 Mar 2014 10:25:15 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.14 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:25:15 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t1050-large.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t1050-large.sh b/t/t1050-large.sh index fd10528..aea4936 100755 --- a/t/t1050-large.sh +++ b/t/t1050-large.sh @@ -131,7 +131,7 @@ test_expect_success 'git-show a large file' ' ' =20 test_expect_success 'index-pack' ' - git clone file://"`pwd`"/.git foo && + git clone file://"$(pwd)"/.git foo && GIT_DIR=3Dnon-existent git index-pack --strict --verify foo/.git/obje= cts/pack/*.pack ' =20 @@ -140,7 +140,7 @@ test_expect_success 'repack' ' ' =20 test_expect_success 'pack-objects with large loose object' ' - SHA1=3D`git hash-object huge` && + SHA1=3D$(git hash-object huge) && test_create_repo loose && echo $SHA1 | git pack-objects --stdout | GIT_ALLOC_LIMIT=3D0 GIT_DIR=3Dloose/.git git unpack-objects && --=20 1.7.10.4