From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 028/142] t2102-update-index-symlinks.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:22:49 -0700 Message-ID: <1395768283-31135-29-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:49 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVE9-0004n1-L2 for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:29 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755607AbaCYRcu convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:32:50 -0400 Received: from mail-pb0-f51.google.com ([209.85.160.51]:65497 "EHLO mail-pb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932108AbaCYRZW (ORCPT ); Tue, 25 Mar 2014 13:25:22 -0400 Received: by mail-pb0-f51.google.com with SMTP id uo5so748052pbc.38 for ; Tue, 25 Mar 2014 10:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=473hZYb0NCw/FGXzDCqbUdiI27tZK58f9Z5sbmD9P7M=; b=IIi0N8FWc5KKJ4n5bhBs8TLetdB/VWaaJB7Wge8FpeKrIJVm/9hzLLEwPer9cEuTDY ZaDMp1yn9C/do/XFaZQijNGNuuUFfyRCDKoDZetMq/BdZmFQm1RzIy+5K5VhyMkuDVOt oaUK70KeBH4D2/gClEzSZXuiTVVQIC04tq078oBYtDsPY3nHPmN34g/7yDsx682pA3Kr iLGKgJG0OmcERhY6JqySoM5fWooUHBnJiJrSSJGObxrv6eEJiRVGWBimWyZ2fYLA/Ciy IoLjKjVIzbG1bJWsGL4zXR2TcVaf/O3hQd//NeSaxD4860hms5a7fnlqDe3rs4hXKpDX DOTQ== X-Received: by 10.67.5.7 with SMTP id ci7mr78993449pad.99.1395768321949; Tue, 25 Mar 2014 10:25:21 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.20 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:25:21 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t2102-update-index-symlinks.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t2102-update-index-symlinks.sh b/t/t2102-update-index-sy= mlinks.sh index 4d0d0a3..22f2c73 100755 --- a/t/t2102-update-index-symlinks.sh +++ b/t/t2102-update-index-symlinks.sh @@ -23,7 +23,7 @@ git update-index symlink' =20 test_expect_success \ 'the index entry must still be a symbolic link' ' -case "`git ls-files --stage --cached symlink`" in +case "$(git ls-files --stage --cached symlink)" in 120000" "*symlink) echo pass;; *) echo fail; git ls-files --stage --cached symlink; (exit 1);; esac' --=20 1.7.10.4