From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 031/142] t3101-ls-tree-dirname.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:22:52 -0700 Message-ID: <1395768283-31135-32-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:32:48 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVDP-0004n1-JZ for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:43 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932120AbaCYRZ3 convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:25:29 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:52438 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932102AbaCYRZZ (ORCPT ); Tue, 25 Mar 2014 13:25:25 -0400 Received: by mail-pa0-f50.google.com with SMTP id kq14so734483pab.23 for ; Tue, 25 Mar 2014 10:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=4WUoN2gSj/ytwQUJPYs5iAHkDnJMMfkLjpRMzCYDvYs=; b=uYU5T1lmec5MsbFf3vHuHKwgBXLU/tlN1uluE4QpDC5Lq3eN5dsXRLLcBUrHRC1N6U 6chrDsSMI7z2qG1JlCYbICAFZrnHZ1VVDXnUBLNpGZ3PhwmeaIaLSH/zU8+ajvmvcECy ejG9iezTPPim3uxSepsgBLE/1YfLyq6utu/vaaPFRNkCO2iDyMq39D2vnPsss1pgCIff ARZcrZTo7RJPB2c+atEskgWAru6QyFkta499jSGHorttA8r6Gxt4RSw8xRU5BVAhG2jd wfNbl/wAaeaGfOOWzesfpzhMyOmDBPtLAjlen7fVRGFdwEnlTabh1A/ikBOA7ay7hp55 GiUQ== X-Received: by 10.66.240.4 with SMTP id vw4mr80009843pac.26.1395768325556; Tue, 25 Mar 2014 10:25:25 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.24 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:25:24 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t3101-ls-tree-dirname.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t3101-ls-tree-dirname.sh b/t/t3101-ls-tree-dirname.sh index 026f9f8..425d858 100755 --- a/t/t3101-ls-tree-dirname.sh +++ b/t/t3101-ls-tree-dirname.sh @@ -35,7 +35,7 @@ test_expect_success 'setup' ' echo 222 >path3/2.txt && find *.txt path* \( -type f -o -type l \) -print | xargs git update-index --add && - tree=3D`git write-tree` && + tree=3D$(git write-tree) && echo $tree ' =20 --=20 1.7.10.4