From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 046/142] t4057-diff-combined-paths.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:23:07 -0700 Message-ID: <1395768283-31135-47-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:32:53 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVDT-0004n1-Ou for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:48 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755358AbaCYRZt convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:25:49 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:42491 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755362AbaCYRZn (ORCPT ); Tue, 25 Mar 2014 13:25:43 -0400 Received: by mail-pd0-f182.google.com with SMTP id y10so720190pdj.13 for ; Tue, 25 Mar 2014 10:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=dCQXTb0xbYqVK5pVeNGM2KcaXyQ/8Myuw3F0YQ7Y+/E=; b=WP7yKrcLklLB4g/mF2cS1Nskx7j3OjykVWzhhl5PO4FdO642sO5EAlIG3ydF009b4M aA0prIUDRFwb4mJ8eOGTaboAj4SBgAgHh8/g7M2Oja/oLobQ4uZekNevyg49Dg2Urrq0 03FY2Y4KBvd0WN3SWNwEc7V7NVtBeevmlxhUo0OYIeNWdCuqsdPBXaSgVmWytrTwmxzx tM56rlus7MmJBPd5sL6qahrtdP+r5StkQIDTNeYCcOOoeOfauwsvFkT5aPXSI3XJyL7q eJ9SE57quKkTZyCYXLLzJP1+Ag+aAtw87P0q/rUqhok13zYshIBxHR9fGhRA615tJKgs q61w== X-Received: by 10.67.8.102 with SMTP id dj6mr80318337pad.10.1395768342851; Tue, 25 Mar 2014 10:25:42 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.25.41 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:25:42 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t4057-diff-combined-paths.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4057-diff-combined-paths.sh b/t/t4057-diff-combined-pat= hs.sh index 097e632..dff36b7 100755 --- a/t/t4057-diff-combined-paths.sh +++ b/t/t4057-diff-combined-paths.sh @@ -5,7 +5,7 @@ test_description=3D'combined diff show only paths that = are different to all parent . ./test-lib.sh =20 # verify that diffc.expect matches output of -# `git diff -c --name-only HEAD HEAD^ HEAD^2` +# $(git diff -c --name-only HEAD HEAD^ HEAD^2) diffc_verify () { git diff -c --name-only HEAD HEAD^ HEAD^2 >diffc.actual && test_cmp diffc.expect diffc.actual --=20 1.7.10.4