From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 005/142] git-rebase.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:22:26 -0700 Message-ID: <1395768283-31135-6-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:25 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVE3-0004n1-QQ for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:24 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755262AbaCYRbz convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:31:55 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:60715 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932139AbaCYRZj (ORCPT ); Tue, 25 Mar 2014 13:25:39 -0400 Received: by mail-pb0-f52.google.com with SMTP id rr13so746106pbb.39 for ; Tue, 25 Mar 2014 10:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=meXSrokQwvNr2SAPBQ6jaXWAsoOWIpcj9mbs9gIfMQo=; b=rHmGIyh0VwaVsA+jE9g6bvt5whGGLUurYr+vFbrLyF+LMRg8wg6sbOiN72XiH3msCy RaeoGfNf9H/uGMiTQIlU2inuxw/mCWNM4dYG/h8qCGQcdktbCuFBK6UFKL7T6TYO+svy asXIUHoL4AfsLjXafPIYBLW+uBlXKDvpriRDgQbmrr7nufQuKWdVGOdO3iQ9g434Xx9R LZmP3sL2/TSTd/GPtwvjL5AhKl7iEWygcjoh9yticBLcU592UMGykeVcX2UU6V0IP0gK E1m/I+Wbyq6s+peNrhxPymQFKWDVRvxDrW8sKGBTPo2r7Mh4cu5LvpJ1vGNZJMpnIGXS E2qQ== X-Received: by 10.66.145.166 with SMTP id sv6mr81148138pab.31.1395768293471; Tue, 25 Mar 2014 10:24:53 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.24.51 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:24:52 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- git-rebase.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/git-rebase.sh b/git-rebase.sh index 5f6732b..a209ab9 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -462,8 +462,8 @@ then else if test -z "$onto" then - empty_tree=3D`git hash-object -t tree /dev/null` - onto=3D`git commit-tree $empty_tree