From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 066/142] t5520-pull.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:23:27 -0700 Message-ID: <1395768283-31135-67-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:32:59 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVDZ-0004n1-HR for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:53 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755419AbaCYR0K convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:26:10 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:40143 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755412AbaCYR0I (ORCPT ); Tue, 25 Mar 2014 13:26:08 -0400 Received: by mail-pa0-f45.google.com with SMTP id kl14so739095pab.18 for ; Tue, 25 Mar 2014 10:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ZeNpsvOgUfvrBkCLQfmRXKeWOlIWlmL9G3lsy5eS3H4=; b=i7/Rp7jvDf9WKN2twBMPkniLb6jzPgu1wL9U7Es86Ei6v2lLAi8R+l3h4pl/5LkU+Q Ykkpcp3z1axcIBSy/9NCqsC7cxTFdTXNfsOOj2sIi9I0GOyevsRu2nPNyEEx5c9U8rxM 6XBS6hsiDWtYsA57qKaQhFPRJ2fjOjTUHiIrFQmJxd9+g21OqNTbuEPnd4ZirD35nRh3 6CXhgq4xLEmHaKtkEfcup7QDxxyC7dK9/CZXxtAF/BDw2PxU+YxIDW+MYhU3ne8xP6PO K/LlHOwseFVwQ/INGXXgFadL5vo5lLcS1hzc3JFVRpBwED5SFcqP6G2IYBqWsM3H4VwM Uyhw== X-Received: by 10.66.145.166 with SMTP id sv6mr81154336pab.31.1395768364280; Tue, 25 Mar 2014 10:26:04 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.03 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:26:03 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t5520-pull.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/t/t5520-pull.sh b/t/t5520-pull.sh index 227d293..a68c099 100755 --- a/t/t5520-pull.sh +++ b/t/t5520-pull.sh @@ -9,7 +9,7 @@ modify () { mv "$2.x" "$2" } =20 -D=3D`pwd` +D=3D$(pwd) =20 test_expect_success setup ' =20 @@ -94,9 +94,9 @@ test_expect_success 'test . as a remote' ' echo updated >file && git commit -a -m updated && git checkout copy && - test `cat file` =3D file && + test $(cat file) =3D file && git pull && - test `cat file` =3D updated + test $(cat file) =3D updated ' =20 test_expect_success 'the default remote . should not break explicit pu= ll' ' @@ -105,9 +105,9 @@ test_expect_success 'the default remote . should no= t break explicit pull' ' git commit -a -m modified && git checkout copy && git reset --hard HEAD^ && - test `cat file` =3D file && + test $(cat file) =3D file && git pull . second && - test `cat file` =3D modified + test $(cat file) =3D modified ' =20 test_expect_success '--rebase' ' --=20 1.7.10.4