From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 069/142] t5537-fetch-shallow.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:23:30 -0700 Message-ID: <1395768283-31135-70-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:07 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVDa-0004n1-N3 for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:55 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932141AbaCYR0N convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:26:13 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:48215 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754717AbaCYR0H (ORCPT ); Tue, 25 Mar 2014 13:26:07 -0400 Received: by mail-pa0-f53.google.com with SMTP id ld10so734995pab.40 for ; Tue, 25 Mar 2014 10:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=N1+2D/TaP3syRVQ/bxMb+wD83EbQEiW5b/7IJzDi618=; b=VHdNr7OsxvpA2IWFaXLj8N/JwH+KNZuuGH/Xs3r2TBTMpG7wnxV015fHYrGel+7XiN YBivDZbpP6MkwrRO6ssvDlp6TCvQYKHyoagGROZvKi1FrZ+xXAhmtbpV178+f0WVXu3w qXIr0TmB8Yg0LwzgCLfn9ie+98xlUBIZFbNfjaxQi7BOLpZBpyQoXSGSyCNEeK7zZcyQ wLB8JTSJ4L7T6Qpe0+Gy3jwypZKmKW2PpctpIC+zWh1Gqr+DyM1vAnkvjJqyzHR9pdVO tbWlFavkbdg+8e+qAm1VXlmHVSSSlw6uu0U+q913aTU3GWamHtztTaABNmljs+//wfXA DN3A== X-Received: by 10.68.60.225 with SMTP id k1mr80367664pbr.58.1395768367272; Tue, 25 Mar 2014 10:26:07 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.06 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:26:06 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t5537-fetch-shallow.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh index be951a4..d9ea98a 100755 --- a/t/t5537-fetch-shallow.sh +++ b/t/t5537-fetch-shallow.sh @@ -98,7 +98,7 @@ EOF test_expect_success 'fetch something upstream has but hidden by client= s shallow boundaries' ' # the blob "1" is available in .git but hidden by the # shallow2/.git/shallow and it should be resent - ! git --git-dir=3Dshallow2/.git cat-file blob `echo 1|git hash-object= --stdin` >/dev/null && + ! git --git-dir=3Dshallow2/.git cat-file blob $(echo 1|git hash-objec= t --stdin) >/dev/null && echo 1 >1.t && git add 1.t && git commit -m add-1-back && @@ -114,7 +114,7 @@ add-1-back EOF test_cmp expect actual ) && - git --git-dir=3Dshallow2/.git cat-file blob `echo 1|git hash-object -= -stdin` >/dev/null + git --git-dir=3Dshallow2/.git cat-file blob $(echo 1|git hash-object = --stdin) >/dev/null =20 ' =20 --=20 1.7.10.4