From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 077/142] t5900-repo-selection.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:23:38 -0700 Message-ID: <1395768283-31135-78-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:27 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVDq-0004n1-A4 for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:10 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755261AbaCYR2s convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:28:48 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:36247 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755425AbaCYR0T (ORCPT ); Tue, 25 Mar 2014 13:26:19 -0400 Received: by mail-pb0-f42.google.com with SMTP id rr13so757182pbb.1 for ; Tue, 25 Mar 2014 10:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=K4Wo9ftUDvVG6YRtkSNxMhPYQCo4CU4Pmw06P4KRcII=; b=HZPd6j7oxvKmoKzgBN3jrgLg1lyzYSTWebReAxmE/DtH7H7MizKgPSA/c/z0bW7np9 emlMO6omk0+NN2g2spd4Sst+lqtUyjnLhw2byLlJBvEmD6Lt0U6tq3etV/A6k7UvXYe9 5YGjj76euuUHrYEfAv8E0tqQp8ZLvmlBJahV6eNrvBKo/KgPormk2v0NU+5XCIry/Z6e jTGXN5avCD8kCmYh17vugZRVQCKTQzkokFjaecV7XC7H7+vv1e3qUBWtv2lt97yMzGSp NFf+oYrpN3nYFjifyTNCnkNey46yzNai11yqKdDfaDtYoGPQ0eTwLYBWg73E0f5jMU5S NiRA== X-Received: by 10.66.5.135 with SMTP id s7mr11720131pas.154.1395768375921; Tue, 25 Mar 2014 10:26:15 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.14 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:26:15 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t5900-repo-selection.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5900-repo-selection.sh b/t/t5900-repo-selection.sh index 3d5b418..14e59c5 100755 --- a/t/t5900-repo-selection.sh +++ b/t/t5900-repo-selection.sh @@ -15,7 +15,7 @@ make_tree() { make_bare() { git init --bare "$1" && (cd "$1" && - tree=3D`git hash-object -w -t tree /dev/null` && + tree=3D$(git hash-object -w -t tree /dev/null) && commit=3D$(echo "$1" | git commit-tree $tree) && git update-ref HEAD $commit ) --=20 1.7.10.4