From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 079/142] t6002-rev-list-bisect.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:23:40 -0700 Message-ID: <1395768283-31135-80-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:12 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVDq-0004n1-Rl for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:33:11 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755425AbaCYR2t convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:28:49 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:41167 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755423AbaCYR0S (ORCPT ); Tue, 25 Mar 2014 13:26:18 -0400 Received: by mail-pa0-f45.google.com with SMTP id kl14so744831pab.4 for ; Tue, 25 Mar 2014 10:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=szA8xYnHR1J7hMrGohwA32GzKE3UJUe0vXqoq7mWQdM=; b=cgYugWVjG4Qr7TGNTpHXK0zaGX5EUswUDQSCLIQiQhiiVgmGj1ITDz1zdeSIbrBDKc 0ixTh2tSmJ8fnYJiT2Sl8eg3p12K+LJfDGbGESln5ArnxLNuyUvwkOiwlcSHV+IdlVcz PMp7yeLR3iKf1/zJ9EZ1ltEFCBbYDZFRVyq3HaPsF3P7uzWT9yB+PFTVjlcVQ0DX0RA7 MMCfFkL7DQKsMtuiRJsqYAqcjVkHTksUPnofc/1eQTcDrdycuYhoD9gGlMFf9kXoXyWo XeSXp2lVnQuI3G7s2LF9SBJ0/kLsgirN/ZMyM6dw7HCFGsU26zO4vEZYp9jdeode+Iir NqzA== X-Received: by 10.66.141.165 with SMTP id rp5mr80752044pab.90.1395768378174; Tue, 25 Mar 2014 10:26:18 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.17 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:26:17 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t6002-rev-list-bisect.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t6002-rev-list-bisect.sh b/t/t6002-rev-list-bisect.sh index 43ad772..3bf2759 100755 --- a/t/t6002-rev-list-bisect.sh +++ b/t/t6002-rev-list-bisect.sh @@ -27,9 +27,9 @@ test_bisection_diff() # Test if bisection size is close to half of list size within # tolerance. # - _bisect_err=3D`expr $_list_size - $_bisection_size \* 2` - test "$_bisect_err" -lt 0 && _bisect_err=3D`expr 0 - $_bisect_err` - _bisect_err=3D`expr $_bisect_err / 2` ; # floor + _bisect_err=3D$(expr $_list_size - $_bisection_size \* 2) + test "$_bisect_err" -lt 0 && _bisect_err=3D$(expr 0 - $_bisect_err) + _bisect_err=3D$(expr $_bisect_err / 2) ; # floor =20 test_expect_success \ "bisection diff $_bisect_option $_head $* <=3D $_max_diff" \ --=20 1.7.10.4