From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elia Pinto Subject: [PATCH v2 083/142] t6132-pathspec-exclude.sh: use the $( ... ) construct for command substitution Date: Tue, 25 Mar 2014 10:23:44 -0700 Message-ID: <1395768283-31135-84-git-send-email-gitter.spiros@gmail.com> References: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Elia Pinto To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 25 18:33:03 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WSVDf-0004n1-0e for gcvg-git-2@plane.gmane.org; Tue, 25 Mar 2014 18:32:59 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754222AbaCYR02 convert rfc822-to-quoted-printable (ORCPT ); Tue, 25 Mar 2014 13:26:28 -0400 Received: from mail-pb0-f48.google.com ([209.85.160.48]:64751 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755431AbaCYR0X (ORCPT ); Tue, 25 Mar 2014 13:26:23 -0400 Received: by mail-pb0-f48.google.com with SMTP id md12so745747pbc.21 for ; Tue, 25 Mar 2014 10:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=6FzU9NMbgD+vDJD4NtKAJj0Q5Tg/YEeY3+ZHyJ83Pv4=; b=b0ad0jzB6BuM+JWvWz45bFImNgSE2xJK/qCztIPi/mFEV7LHhqq+OM5zoF99/mW/UL qqHEP1dR69Kr3ms9+6Lt4eMA7q65ttafM2yCFbOdiGY7n/2DgaC6mcmnR4lPHrH6jxR1 6zHEZeslBuQB/IAIsuNdoperEpswJ1y63EbPLPWHjhTx6d0GkW4HhzAke8LVAMbKOVRm SFR1HzIUwrwdZdCTvnMrSkXWOMv58V6otpwAX6+UNDKK7gp5DHL09CSPRRoCHwnsI/Gq 4U2aiCMxqj2RXeViVxpHn9znwilLVhM2md1jikJTcJm692gBhnNPQHINozi14PrFcfm6 GAdg== X-Received: by 10.66.193.202 with SMTP id hq10mr80509886pac.57.1395768383023; Tue, 25 Mar 2014 10:26:23 -0700 (PDT) Received: from devzero2000ubu.nephoscale.com (140.195.207.67.nephoscale.net. [67.207.195.140]) by mx.google.com with ESMTPSA id x5sm47105136pbw.26.2014.03.25.10.26.21 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 10:26:22 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backs= lash character. Because of this the POSIX shell adopted the $(=E2=80=A6) fea= ture from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do =C2=A0 sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t6132-pathspec-exclude.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t6132-pathspec-exclude.sh b/t/t6132-pathspec-exclude.sh index 62049be..801afae 100755 --- a/t/t6132-pathspec-exclude.sh +++ b/t/t6132-pathspec-exclude.sh @@ -7,7 +7,7 @@ test_description=3D'test case exclude pathspec' test_expect_success 'setup' ' for p in file sub/file sub/sub/file sub/file2 sub/sub/sub/file sub2/f= ile; do if echo $p | grep /; then - mkdir -p `dirname $p` + mkdir -p $(dirname $p) fi && : >$p && git add $p && --=20 1.7.10.4